-
Notifications
You must be signed in to change notification settings - Fork 6.7k
chore(deps): update dependency websockets to v16 #13736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update dependency websockets to v16 #13736
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the websockets dependency to version 16.0. This is a major version upgrade, which often comes with breaking changes. I've left a specific comment on the dependency change in requirements.txt detailing a necessary refactoring for websockets imports across the codebase. Please ensure that the application is thoroughly tested with this new version and that the suggested refactoring is addressed in a follow-up to maintain code health and prevent future breakages.
| google-genai==1.42.0 | ||
| scipy==1.16.1 | ||
| websockets==15.0.1 | ||
| websockets==16.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating websockets to a new major version (16.0) introduces breaking changes and new best practices. The library now recommends importing connect directly from the top-level package.
To align with this, please update the existing imports from from websockets.asyncio.client import connect to from websockets import connect.
This change should be applied in files such as:
live_websocket_audiogen_with_txt.pylive_websocket_audiotranscript_with_txt.pylive_websocket_textgen_with_audio.pylive_websocket_textgen_with_txt.py
Since these files are not part of this PR, this change will need to be handled in a follow-up.
This PR contains the following updates:
==15.0.1→==16.0Release Notes
python-websockets/websockets (websockets)
v16.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.