feat: encountered negative pressure/density cells summary output#3677
Open
feat: encountered negative pressure/density cells summary output#3677
Conversation
…on CPU but doesn't on GPU build + suboptimal
…unt from kernels (optionally)
… logLevel "SolutionDetails"
…ve-pressure-cells
…ve-pressure-cells
Contributor
Author
|
@paveltomin I did a benchmark with a real case of 1M+ cells, with the different |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at adding a partial logging of the element ids that have negative pressures / densities, to allow the user to quickly see where negative pressure / densities are computed.
To enable the output, it is proposed to set the
logLevelat least to 2 on the flow solver.Here is an exemple of an output (from a synthetic case):
A standard component is proposed to do so this kind of "limited kernel output": the
ElementReporterOutput& . Its goal is to:ElementReporterBuffer, allocate global memory & be able to disable the whole system (ie: by alogLevel),ElementReporterCollector, manage the atomic counting & collection of elements,ElementReporterOutput, output the result (i.e. in the log),If the number of reported elements exceed the rank
ElementReporterBuffersize, the row ends with..., but the elements still gets counted.This table has been drawn by the new
TableTextMpiOutput(also proposed in this PR), which allows to draw a single table on the rank 0 from multiple ranks: