use specific implementation to get available host memory on MacOS#2597
use specific implementation to get available host memory on MacOS#2597
Conversation
herve-gross
left a comment
herve-gross
left a comment
There was a problem hiding this comment.
The code now compiles without issues on my Mac. Thanks for fixing this!
There was a problem hiding this comment.
Could you instead encapsulate this implementation and all system-specific includes in a separate translation unit (.cpp)? I think LvArray/system.[h/c]pp would be a good place to expose this functionality, if you can spare the effort to open an LvArray PR.
There was a problem hiding this comment.
I'll change that, I tend to avoid commiting to LvArray as it is another project but another translation unit would be cleaner.
There was a problem hiding this comment.
Maybe indicate in the function name that this is for host/system memory?
XL64
changed the title
rrsettgast
requested review from
CusiniM,
MelReyCG,
corbett5 and
wrtobin
as code owners
|
@herve-gross still needed or close? |
|
This was fixed. We can close it. |
6 participants
This fixes a compilation error on MacOS where the method to obtain the current memory available on host doesn't not build because _SC_AVPHYS_PAGES is not available.