Fix for #356, multiple class adapted for the feature.#357
Open
perilbrain wants to merge 2 commits intoFasterXML:3.xfrom
Open
Fix for #356, multiple class adapted for the feature.#357perilbrain wants to merge 2 commits intoFasterXML:3.xfrom
perilbrain wants to merge 2 commits intoFasterXML:3.xfrom
Conversation
- Accepts new annotation for collection type.
perilbrain
changed the title
This functional usually called from the factories of various frameworks like spring needs to resolve the the type of `value` directly rather than trying to figure parameter of some generic.
perilbrain
commented
Aug 24, 2019
src/main/java/com/fasterxml/jackson/dataformat/xml/ser/XmlSerializerProvider.java
Outdated
Show resolved
Hide resolved
Member
|
Ah, this looks good I think; I will try to go through with it in more detail, but wanted to mention that this is on my radar for things to go in 2.10 (but I'm also bit overload with all changes :) ). Only one more question: have I already asked for CLA? If not, it's here: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and we'd need a filled copy before first merged contribution (apologies if I have already asked and gotten one). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(fix for #356)
Hey I have made a few improvements to fix the issue. All tests cases are passing but I definitely need a review for this commit.