Movidos los informes de Impuestos y Productos del core al plugin by daniel89fg · Pull Request #71 · FacturaScripts/informes

daniel89fg · 2026-02-12T10:13:00Z

necesita el pr del core: NeoRazorX/facturascripts#1887

Copilot

Pull request overview

Este PR traslada informes de Impuestos (Taxes) y Productos desde el core al plugin Informes, añadiendo los controladores, vistas Twig, XMLViews y modelos Join necesarios para que los reportes funcionen desde el plugin.

Changes:

Añade el reporte de impuestos (UI Twig + controlador exportador).
Añade el reporte de productos con vistas ListController y modelos Join para facturas/albaranes de cliente y proveedor.
Incorpora las definiciones XMLView para las listas de productos en facturas de cliente/proveedor.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
XMLView/FacturaProveedorProducto.xml	Define columnas/estado para el listado de productos en facturas de proveedor.
XMLView/FacturaClienteProducto.xml	Define columnas/estado para el listado de productos en facturas de cliente.
View/ReportTaxes.html.twig	Interfaz del reporte de impuestos (filtros, selección de columnas y exportación).
Model/Join/FacturaProveedorProducto.php	JoinModel agregado para reporte de productos en facturas de proveedor.
Model/Join/FacturaClienteProducto.php	JoinModel agregado para reporte de productos en facturas de cliente.
Model/Join/AlbaranProveedorProducto.php	Especialización para albaranes de proveedor.
Model/Join/AlbaranClienteProducto.php	Especialización para albaranes de cliente.
Controller/ReportTaxes.php	Lógica del reporte de impuestos (cálculo, validación de totales, export).
Controller/ReportProducto.php	ListController del reporte de productos con filtros comunes y vistas por documento.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T10:20:31Z

View/ReportTaxes.html.twig

+                                                {% if empresa.idempresa == fsc.idempresa %}
+                                                    <option value="{{ empresa.idempresa }}" selected>
+                                                        {{ empresa.nombrecorto | raw }}
+                                                    </option>
+                                                {% else %}
+                                                    <option value="{{ empresa.idempresa }}">
+                                                        {{ empresa.nombrecorto | raw }}
+                                                    </option>


The select option labels are rendered with the |raw filter (company/serie/currency/country descriptions). These values typically come from the database and should be escaped to avoid XSS; remove |raw (or explicitly sanitize/escape the fields before rendering) unless HTML is intentionally allowed and guaranteed safe.

Copilot · 2026-02-12T10:20:32Z

View/ReportTaxes.html.twig

+                            <h1 class="h3 mb-1">
+                                <i class="{{ fsc.getPageData().icon }} me-2"></i> {{ fsc.title }}
+                            </h1>
+                            <p class="text-muted mb-4">{{ trans('report-taxes-p') }}.</p>


trans('report-taxes-p') is used for user-visible text, but this key isn't present in this plugin's Translation/*.json files. If the report has been moved out of core, the plugin should ship the required translation keys (also for other new strings used by this view/controller) to avoid showing raw keys in the UI.

Suggested change

<p class="text-muted mb-4">{{ trans('report-taxes-p') }}.</p>

<p class="text-muted mb-4">Select the company, period, and filters to generate the taxes report.</p>

Copilot · 2026-02-12T10:20:32Z

Controller/ReportTaxes.php

+        // recorremos los datos recibidos
+        foreach ($this->request->request->all() as $key => $value) {
+            // obtenemos la key sin el column_
+            $column = substr($key, 7);
+
+            // reemplazamos _ por -
+            $column = str_replace('_', '-', $column);
+
+            // traducimos la columna
+            $column = Tools::trans($column);
+
+            // si la key empieza por column_ y no está en el array de columnas, la añadimos
+            if (strpos($key, 'column_') === 0 && !in_array($column, $this->columns)) {
+                $this->columns[] = $column;
+            }


initColumns() translates/transforms every POST key before checking the column_ prefix. This does unnecessary work for unrelated fields (action, token, dates, etc.) and makes the logic harder to follow. Check strpos($key, 'column_') === 0 first, then derive/translate the column name only for matching keys.

Copilot · 2026-02-12T10:20:32Z

Controller/ReportProducto.php

+        // dirección y envío
+        $this->addFilterAutocomplete($viewName, 'idcontactofact', 'billing-address', 'idcontactofact', 'contactos', 'idcontacto', 'direccion');
+        $this->addFilterautocomplete($viewName, 'idcontactoenv', 'shipping-address', 'idcontactoenv', 'contactos', 'idcontacto', 'direccion');
+


Method call casing is inconsistent (addFilterautocomplete vs addFilterAutocomplete). PHP will call it, but keeping the canonical method name improves readability and avoids confusion with static analysis / IDE tooling.

Copilot · 2026-02-12T10:20:32Z

Controller/ReportProducto.php

+        // dirección y envio
+        $this->addFilterAutocomplete($viewName, 'idcontactofact', 'billing-address', 'idcontactofact', 'contactos', 'idcontacto', 'direccion');
+        $this->addFilterautocomplete($viewName, 'idcontactoenv', 'shipping-address', 'idcontactoenv', 'contactos', 'idcontacto', 'direccion');
+


Method call casing is inconsistent (addFilterautocomplete vs addFilterAutocomplete). PHP will call it, but keeping the canonical method name improves readability and avoids confusion with static analysis / IDE tooling.

Copilot · 2026-02-12T10:20:33Z

XMLView/FacturaProveedorProducto.xml

+    </columns>
+    <rows>
+        <row type="status">
+            <option color="warning" fieldname="descripcion" title="empty-ref-or-missing">null:</option>


The status option uses title="empty-ref-or-missing", but this translation key is not present in this plugin's Translation/*.json files. If this report/view was moved from core, ensure the plugin includes this (and any other newly referenced) translation keys to avoid showing raw keys in the UI.

Suggested change

<option color="warning" fieldname="descripcion" title="empty-ref-or-missing">null:</option>

<option color="warning" fieldname="descripcion">null:</option>

Copilot · 2026-02-12T10:20:33Z

XMLView/FacturaClienteProducto.xml

+    </columns>
+    <rows>
+        <row type="status">
+            <option color="warning" fieldname="descripcion" title="empty-ref-or-missing">null:</option>


The status option uses title="empty-ref-or-missing", but this translation key is not present in this plugin's Translation/*.json files. If this report/view was moved from core, ensure the plugin includes this (and any other newly referenced) translation keys to avoid showing raw keys in the UI.

Suggested change

<option color="warning" fieldname="descripcion" title="empty-ref-or-missing">null:</option>

<option color="warning" fieldname="descripcion">null:</option>

Copilot · 2026-02-12T10:20:33Z

Controller/ReportTaxes.php

+                Tools::trans('pct-tax') => $this->exportFieldFormat('number', $row['iva']),
+                Tools::trans('tax') => $this->exportFieldFormat('number', $row['totaliva']),
+                Tools::trans('pct-surcharge') => $this->exportFieldFormat('number', $row['recargo']),
+                Tools::trans('surcharge') => $this->exportFieldFormat('number', $row['totalrecargo']),
+                Tools::trans('pct-irpf') => $this->exportFieldFormat('number', $row['irpf']),


These fields are percentages (iva, recargo, irpf) but are formatted using the number formatter, so PDF exports will miss the % suffix and be inconsistent with the totals table (which uses percentage). Use the percentage formatter for these columns in the lines table as well.

Suggested change

Tools::trans('pct-tax') => $this->exportFieldFormat('number', $row['iva']),

Tools::trans('tax') => $this->exportFieldFormat('number', $row['totaliva']),

Tools::trans('pct-surcharge') => $this->exportFieldFormat('number', $row['recargo']),

Tools::trans('surcharge') => $this->exportFieldFormat('number', $row['totalrecargo']),

Tools::trans('pct-irpf') => $this->exportFieldFormat('number', $row['irpf']),

Tools::trans('pct-tax') => $this->exportFieldFormat('percentage', $row['iva']),

Tools::trans('tax') => $this->exportFieldFormat('number', $row['totaliva']),

Tools::trans('pct-surcharge') => $this->exportFieldFormat('percentage', $row['recargo']),

Tools::trans('surcharge') => $this->exportFieldFormat('number', $row['totalrecargo']),

Tools::trans('pct-irpf') => $this->exportFieldFormat('percentage', $row['irpf']),

Copilot · 2026-02-12T10:20:34Z

Controller/ReportProducto.php

+    {
+        $this->addView($viewName, 'Join\FacturaProveedorProducto', 'supplier-invoices', 'fa-solid fa-copy')
+            ->addSearchFields(['productos.descripcion', 'lineasfacturasprov.referencia'])
+            ->addOrderBy(['cantidad'], 'quantity', 2);


The order-by label key uses 'quantity', but the view/column naming elsewhere uses 'purchased-quantity' for supplier quantities (and the XMLView defines purchased-quantity). This likely results in an inconsistent label in the UI; consider using the same translation key as the column (purchased-quantity).

Suggested change

->addOrderBy(['cantidad'], 'quantity', 2);

->addOrderBy(['cantidad'], 'purchased-quantity', 2);

Movidos los informes de Impuestos y Productos del core al plugin

0fc2222

Copilot AI review requested due to automatic review settings February 12, 2026 10:13

Copilot started reviewing on behalf of daniel89fg February 12, 2026 10:13 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Movidos los informes de Impuestos y Productos del core al plugin#71

Movidos los informes de Impuestos y Productos del core al plugin#71
daniel89fg wants to merge 1 commit intomainfrom
informes-impuestos-productos

daniel89fg commented Feb 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

1 participant

Comments

	<p class="text-muted mb-4">{{ trans('report-taxes-p') }}.</p>
	<p class="text-muted mb-4">Select the company, period, and filters to generate the taxes report.</p>

	<option color="warning" fieldname="descripcion" title="empty-ref-or-missing">null:</option>
	<option color="warning" fieldname="descripcion">null:</option>

	->addOrderBy(['cantidad'], 'quantity', 2);
	->addOrderBy(['cantidad'], 'purchased-quantity', 2);

Conversation

daniel89fg commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

1 participant

Comments

daniel89fg commented Feb 12, 2026 •

edited

Loading