WIP fix: Make storage calls async and await the init task #727

adhorodyski · 2026-01-29T23:48:14Z

@roryabraham @sosek108 @tgolen

Details

This PR makes Onyx storage calls async so we can await the initialization task before executing them.

Related Issues

GH_LINK

Automated Tests

Manual Tests

Author Checklist

I linked the correct issue in the ### Related Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

tgolen · 2026-01-30T01:49:59Z

lib/Onyx.ts

I think we still need to return promises in all these cases. There is still code that uses them, isn't there?

ordering

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e176ab0db3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-30T02:18:22Z

lib/Onyx.ts

 function update<TKey extends OnyxKey>(data: Array<OnyxUpdate<TKey>>): Promise<void> {
-    // First, validate the Onyx object is in the format we expect
-    for (const {onyxMethod, key, value} of data) {
-        if (!Object.values(OnyxUtils.METHOD).includes(onyxMethod)) {
-            throw new Error(`Invalid onyxMethod ${onyxMethod} in Onyx update.`);
-        }
-        if (onyxMethod === OnyxUtils.METHOD.MULTI_SET) {
-            // For multiset, we just expect the value to be an object
-            if (typeof value !== 'object' || Array.isArray(value) || typeof value === 'function') {
-                throw new Error('Invalid value provided in Onyx multiSet. Onyx multiSet value must be of type object.');
+    return OnyxUtils.getDeferredInitTask().promise.then(() => {
+        // First, validate the Onyx object is in the format we expect
+        for (const {onyxMethod, key, value} of data) {
+            if (!Object.values(OnyxUtils.METHOD).includes(onyxMethod)) {


Preserve synchronous validation errors in update

Wrapping the entire body in getDeferredInitTask().promise.then(...) makes the validation errors throw asynchronously. Callers (and tests like tests/unit/onyxTest.ts around the “should throw an error…” case) currently rely on a synchronous throw from Onyx.update to fail fast when invalid data is passed; with this change, the same misuse becomes an unhandled promise rejection unless every caller awaits/catches the returned promise. This is a behavior change that breaks existing try/catch usage and can let invalid updates slip past immediate error handling.

Useful? React with 👍 / 👎.

melvin-bot bot assigned adhorodyski Jan 29, 2026

tgolen requested changes Jan 30, 2026

View reviewed changes

lib/Onyx.ts

Copy link

Collaborator

tgolen Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to return promises in all these cases. There is still code that uses them, isn't there?

Wait for deferred initialization before Onyx operations to ensure proper

e176ab0

ordering

adhorodyski force-pushed the fix/await-onyx-init branch from 5cf97ad to e176ab0 Compare January 30, 2026 02:05

adhorodyski marked this pull request as ready for review January 30, 2026 02:16

adhorodyski requested a review from a team as a code owner January 30, 2026 02:16

melvin-bot bot requested review from carlosmiceli and removed request for a team January 30, 2026 02:17

chatgpt-codex-connector bot reviewed Jan 30, 2026

View reviewed changes

roryabraham self-requested a review January 30, 2026 02:20

run prettier

fd8dc85

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP fix: Make storage calls async and await the init task #727

WIP fix: Make storage calls async and await the init task #727

adhorodyski commented Jan 29, 2026

Uh oh!

tgolen Jan 30, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

WIP fix: Make storage calls async and await the init task #727

Are you sure you want to change the base?

WIP fix: Make storage calls async and await the init task #727

Conversation

adhorodyski commented Jan 29, 2026

Details

Related Issues

Automated Tests

Manual Tests

Author Checklist

Screenshots/Videos

Uh oh!

tgolen Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants