-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Make Travel panel clickable on More Features page #81056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
trjExpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense for consistency. 👍
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-31.at.16.57.49.mp4Android: mWeb ChromeScreen.Recording.2026-01-31.at.16.59.07.mp4iOS: HybridAppScreen.Recording.2026-01-31.at.17.02.24.mp4iOS: mWeb SafariScreen.Recording.2026-01-31.at.17.04.37.mp4MacOS: Chrome / SafariScreen.Recording.2026-01-31.at.16.52.55.mp4 |
huult
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Explanation of Change
Fixed Issues
$ #81046
PROPOSAL: n/a
Tests
Offline tests
n/a, doesn't touch the API
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari