Add success metric so we can be 100% sure we are sending something#79
Open
EXPEaneparaczki wants to merge 4 commits intoExpediaDotCom:masterfrom
Open
Add success metric so we can be 100% sure we are sending something#79EXPEaneparaczki wants to merge 4 commits intoExpediaDotCom:masterfrom
EXPEaneparaczki wants to merge 4 commits intoExpediaDotCom:masterfrom
Conversation
EXPEaneparaczki
changed the title
v-akerek
previously approved these changes
Jan 16, 2020
Contributor
|
@EXPEaneparaczki we have a timer named 'dispatchTimer'(kinesis.dispatch.timer). That captures time as well as rate at which we send the spans(success + failure). Will that be sufficient? |
Author
|
The timer measures failures as well, still can't ever be sure we are sending data. We would like to have a sole simple easy clean way to check if the agent is sending anything at all |
EXPEaneparaczki
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.