Skip to content

Fix off-by-one in InsertAndShift resize condition (#2291) #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanKallman merged 1 commit into from
Feb 22, 2026
Merged

Fix off-by-one in InsertAndShift resize condition (#2291) #2292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EPPlus/Core/ChangableDictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ internal virtual void InsertAndShift(int fromPosition, int add)
pos = ~pos;
}

if (pos + 1 >= _index[0].Length - 1)
if (_count >= _index[0].Length - 1)
{
Array.Resize(ref _index[0], _index[0].Length << 1);
Array.Resize(ref _index[1], _index[1].Length << 1);
Expand Down
18 changes: 18 additions & 0 deletions src/EPPlusTest/Issues/WorksheetIssues.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using OfficeOpenXml.Drawing;
using OfficeOpenXml.Drawing.Chart;
using OfficeOpenXml.FormulaParsing;
using OfficeOpenXml.FormulaParsing.Excel.Functions.Information;
using OfficeOpenXml.FormulaParsing.Excel.Functions.Logical;
using OfficeOpenXml.FormulaParsing.Excel.Functions.MathFunctions;
using OfficeOpenXml.RichData;
Expand Down Expand Up @@ -1112,5 +1113,22 @@ public void i2258()
Assert.AreEqual("Negative 4000,000", d3);
}

[TestMethod]
public void InsertAndShift_ShouldNotThrow_WhenArrayIsFull()
{
using var package = new ExcelPackage();
var sheet = package.Workbook.Worksheets.Add("Sheet1");

// Fill 7 columns with formatting to trigger the boundary condition
for (int col = 1; col <= 7; col++)
{
sheet.Column(col).Width = 15;
}

// These two inserts should not throw ArgumentException
sheet.InsertColumn(3, 1);
sheet.InsertColumn(5, 1);
}

}
}