Open
Conversation
Moved code to use importlib.resources, which is available in Python >=3.9 Fixes EMPRI-DEVOPS#41
fapdash
force-pushed
the
fix-pkgresource
branch
from
2ef8b6a to
a54d7a8
Compare
This was referenced Feb 16, 2026
blochberger
suggested changes
Feb 16, 2026
blochberger
left a comment
blochberger
left a comment
There was a problem hiding this comment.
The change itself looks mostly fine to me. Contrary to what the commit message (or pull request description) indicates, this increases the minimum required Python version, which may impact existing users. Bumping the minimum supported Python version may be fine, but would require some more updates, e.g., to the project's README file.
Note that I'm not the person to decide, whether bumping the minimum version is fine :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved code to use importlib.resources, which is available in Python >=3.9
Fixes #41