Open
Conversation
Collaborator
Author
|
Here is some performance data for ExaMiniMD on a 4 core Linux box
|
|
@stanmoore1 any comments on differences in memory usage for OpenMP and Pthreads vs. using atomics? |
Collaborator
Author
|
There is some memory overhead because the force array is duplicated. The force array is the second largest data structure, after the neighbor list, however typically each atom has many neighbors, so the neighbor list is much larger than the force array, and typically we only duplicate 8 or less times. |
Collaborator
Author
|
Also the numbers for data duplication may be a little better because we fixed this bug: #22. |
|
What's the status of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge yet. This is an example of using the new duplicated memory feature in Kokkos as an alternative to thread atomics, see kokkos/kokkos#1225 and kokkos/kokkos#825. For OpenMP or PThreads it uses a duplicated non-atomic view, for CUDA it still uses a non-duplicated atomic view, and for Serial it uses a non-duplicated, non-atomic view. On my Linux box with OpenMP it does give speedup over atomics. The API/naming may change a bit before it is formally released into Kokkos.
@crtrott