Skip to content

feat: use issuer url instead of well known url#1371

Open
ZohebShaikh wants to merge 2 commits intomainfrom
check-issuer
Open

feat: use issuer url instead of well known url#1371
ZohebShaikh wants to merge 2 commits intomainfrom
check-issuer

Conversation

@ZohebShaikh
Copy link
Contributor

No description provided.

@ZohebShaikh ZohebShaikh changed the title add issuer instead of well known url feat: add issuer instead of well known url Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (e2fd3f0) to head (e0245e3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1371      +/-   ##
==========================================
- Coverage   95.03%   95.03%   -0.01%     
==========================================
  Files          43       43              
  Lines        2782     2779       -3     
==========================================
- Hits         2644     2641       -3     
  Misses        138      138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZohebShaikh ZohebShaikh marked this pull request as ready for review February 3, 2026 14:05
@ZohebShaikh ZohebShaikh requested a review from a team as a code owner February 3, 2026 14:05
@ZohebShaikh ZohebShaikh changed the title feat: add issuer instead of well known url feat: use issuer url instead of well known url Feb 3, 2026
Copy link
Contributor

@tpoliaw tpoliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change - it makes the auth config much clearer, thanks.

That said, this is a breaking change that will need every beamline to update its config and for GDA to support the new API. We have a list of breaking issues that are waiting for a 2.0 release so it might be worth adding an issue there for this change and keeping this PR around until we decide to break everything at once.

@ZohebShaikh ZohebShaikh added this to the Blueapi 2.0.0 milestone Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants