Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
=======================================
Coverage 95.04% 95.04%
=======================================
Files 43 43
Lines 2783 2783
=======================================
Hits 2645 2645
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think this can be move to dev dependencies, but should not be remove because If this happens we will not be able to know if the latest scanspec is working with blueapi. |
|
This is still testing if blueapi can run scanspec scans, it's just not testing the serialization part which isn't normally used by the server. |
|
You are right that the serialisation in not used by the server, but |
|
Where does the client use scanspec? Doesn't it use the JSON object directly? |
|
I might be wrong on this. But might be worth giving it a try. We can always add this back if it starts causing problems |
No description provided.