feat!: Include plan return values in WorkerEvents#1357
Open
Conversation
Contributor
Author
|
This would need a matching change in GDA (back-ported to 9.38?) to add the result type to TaskStatus here. |
Use pydantic to convert result to something that can be JSON serialized later.
tpoliaw
changed the title
Contributor
Author
|
Ignoring the GDA change, I think the blueapi side of this is workable |
tpoliaw
changed the title
Contributor
Author
|
Change in gerrit: https://gerrit.diamond.ac.uk/c/gda/gda-core/+/44673 |
DominicOram
requested changes
Jan 30, 2026
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Looks good, thanks. Should: it would be nice to add some tests on the case where the plan is actually returning something, ideally parametrized against a few different return types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
resultfield to the task status inWorkerEvents.BREAKING CHANGE: This changes the structure of the events sent during plans so will require external clients to be updated to match.