fix: Prevent spans being swallowed by infinite startup span#1246
Open
DiamondJoseph wants to merge 2 commits intomainfrom
Open
fix: Prevent spans being swallowed by infinite startup span#1246DiamondJoseph wants to merge 2 commits intomainfrom
DiamondJoseph wants to merge 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
- Coverage 94.67% 94.67% -0.01%
==========================================
Files 41 41
Lines 2611 2609 -2
==========================================
- Hits 2472 2470 -2
Misses 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiamondJoseph
force-pushed
the
prevent-infinte-trace
branch
from
ca9ab89 to
34fd603
Compare
tpoliaw
force-pushed
the
prevent-infinte-trace
branch
from
34fd603 to
5464b73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1243
Removes the spans for two methods that start either start subprocesses or loop infinitely, meaning the methods that they call can be displayed as unique traces rather than being swallowed into a single trace.