Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
==========================================
- Coverage 95.05% 95.03% -0.03%
==========================================
Files 41 41
Lines 2528 2537 +9
==========================================
+ Hits 2403 2411 +8
- Misses 125 126 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiamondJoseph
left a comment
DiamondJoseph
left a comment
There was a problem hiding this comment.
Nothing blocking so approving but had some comments
| return self._rest.get_active_task() | ||
|
|
||
| @start_as_current_span(TRACER, "task", "timeout") | ||
| @start_as_current_span(TRACER, "name", "parameters", "timeout") |
There was a problem hiding this comment.
Given the problems we've had with the logs being spammed with junk I'm hesitant to add a dict here, but I suppose better to add it and change the underlying behaviour that's causing problems.
There was a problem hiding this comment.
I think the same content would have ended up in the logs when a task was being passed around. It still contained the same dict.
Argument parsing has been moved into a click option validator, and task creation has been moved into the client create_task methods. This is a breaking change in the BlueapiClient as task methods now accept plan name and parameters as separate arguments.
|
Please let me know before this change is merged, because this will break things for me |
|
Removed my +2 and added the 2.0 label so it shouldn't get merged without consideration (already had |
3 participants
Argument parsing has been moved into a click option validator, and task
creation has been moved into the client create_task methods.
This is a breaking change in the BlueapiClient as task methods now
accept plan name and parameters as separate arguments.
Fixes #593 leaving only CLI related code in
run_planincli.py.