fix: change is_admin from array to function#291
Merged
tpoliaw merged 1 commit intoDiamondLightSource:mainfrom Dec 9, 2025
Merged
fix: change is_admin from array to function#291tpoliaw merged 1 commit intoDiamondLightSource:mainfrom
tpoliaw merged 1 commit intoDiamondLightSource:mainfrom
Conversation
ZohebShaikh
changed the title
ZohebShaikh
changed the title
tpoliaw
previously requested changes
Nov 24, 2025
Collaborator
tpoliaw
left a comment
tpoliaw
left a comment
There was a problem hiding this comment.
Both parts look alright but why are they in the same PR?
Why is this implementation of is_admin better than the previous approach?
Collaborator
Author
|
The issue that regal was trying to point out was : If you are storing the result of a decsion and then later using the stored decision then you might have stale decisions... What might happen is lets say alice is currently a super_admin then all the other policy are using this output variable to make a decision whether alice is a super_admin then it will be get the old stored result rather than checking the if alice is a super_admin currently Thats why changing into a function will always give you the correct decision |
ZohebShaikh
changed the title
ZohebShaikh
force-pushed
the
fix-admin-policy
branch
from
0e9837b to
51e2dd1
Compare
ZohebShaikh
changed the title
Collaborator
Author
tpoliaw
approved these changes
Dec 9, 2025
ZohebShaikh
force-pushed
the
fix-admin-policy
branch
from
51e2dd1 to
d21b0aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.