fix: ensure v2ApiClient uses shared axios instance for MCP headers#526
Merged
jonathannorris merged 2 commits intomainfrom Oct 1, 2025
Merged
fix: ensure v2ApiClient uses shared axios instance for MCP headers#526jonathannorris merged 2 commits intomainfrom
jonathannorris merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the v2ApiClient was not using the shared axios instance, causing MCP server API calls to miss required MCP identification headers.
- Updated v2ApiClient creation to use the shared axiosClient instance with proper validation options
- Added test coverage to verify v2ApiClient inherits MCP headers correctly
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/api/apiClient.ts | Modified v2ApiClient creation to use shared axiosClient instance for MCP header inheritance |
| src/mcp/utils/api.test.ts | Added test case to verify v2ApiClient uses shared axios instance with MCP headers |
| src/commands/features/snapshots/update.test.ts.snap | Updated test snapshots due to JSON property ordering changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
devcycle-mcp-server | e5ce2e2 | Oct 01 2025, 03:54 PM |
kaushalkapasi
approved these changes
Oct 1, 2025
JamieSinn
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
v2ApiClientwas not using the sharedaxiosClientinstance, causing all/v2/featuresAPI calls from the MCP server to miss the MCP identification headers (dvc-referreranddvc-referrer-metadata).Solution
v2ApiClientcreation insrc/api/apiClient.tsto use the sharedaxiosClientinstance withvalidate: 'request'option