fix: allow clearing self-targeting identity with empty string#503
Merged
jonathannorris merged 3 commits intomainfrom Aug 27, 2025
Merged
fix: allow clearing self-targeting identity with empty string#503jonathannorris merged 3 commits intomainfrom
jonathannorris merged 3 commits intomainfrom
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
devcycle-mcp-server | 929b529 | Aug 27 2025, 09:15 PM |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the MCP tool for updating self-targeting identity couldn't properly clear the identity field using an empty string. The fix removes the nullable validation from the schema and adds logic to convert empty strings to null in the handler.
- Removed
.nullable()validation fromUpdateSelfTargetingIdentityArgsSchema - Added empty string to null conversion logic in the update handler
- Updated schema description to clarify that empty strings can be used to clear the identity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/mcp/types.ts | Removed nullable validation from UpdateSelfTargetingIdentityArgsSchema |
| src/mcp/tools/selfTargetingTools.ts | Added logic to convert empty strings to null when updating user profile |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kaushalkapasi
approved these changes
Aug 27, 2025
suthar26
approved these changes
Aug 27, 2025
bbcc4f0 to
148a485
Compare
148a485 to
4dd1df8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateSelfTargetingIdentityArgsSchemato require a string (removed.nullable()).updateSelfTargetingIdentityHandler, treat empty string asnullwhen callingupdateUserProfile.Why
nullablewasn't working with MCP call for updating the self-targeting identity