Proposed changes for DataHighway integration with Polkadot.js Apps#2
Conversation
| isDisabled: true, | ||
| text: t('rpc.test.datahighway.spreehafen', 'Spreehafen', { ns: 'apps-config' }), | ||
| providers: { | ||
| MXC: 'wss://spreehafen.datahighway.com' |
There was a problem hiding this comment.
we need to find out the relevance of this being MXC or DataHighway
| info: 'datahighway-harbour', | ||
| text: t('rpc.test.datahighway-harbour', 'DataHighway Harbour', { ns: 'apps-config' }), | ||
| info: 'datahighway-harbour-chain-testnet', | ||
| text: t('rpc.test.datahighway.harbour', 'DataHighway Harbour', { ns: 'apps-config' }), |
There was a problem hiding this comment.
from a maintenance perspective, it might be easier if this was named datahighway-harbour instead of datahighway.harbour since find/replace would be quicker. what do you think?
(same applies to datahighway.spreehafen and datahighway.westlake)
| ['DataHighwayChain', nodeWestlake], | ||
| ['DataHighway Node', nodeDataHighway], | ||
| ['DataHighway Parachain Collator', nodeDataHighway], | ||
| ['DataHighway', nodeDataHighwayDefault], // TODO - deprecated? |
There was a problem hiding this comment.
we should remove all lines that i've labelled // TODO - deprecated? if they're not used anymore
| minmax: [0, undefined], | ||
| types: { | ||
| Date: 'i64', | ||
| AccountInfo: "AccountInfoWithDualRefCount", |
There was a problem hiding this comment.
I tried adding and removing this. App works without it due to recent changes. Let me reverify this.
ayushmishra2005
left a comment
ayushmishra2005
left a comment
There was a problem hiding this comment.
@ltfschoen I am merging this. I will test and make corrections in my branch.
the CI tests are failing for some reason, so we need to resolve that first |
i just pushed a commit to see if that fixes it, will wait for CI to test again |
sure |
i'm not familiar with why we're getting "Semgrep / check (pull_request) Failing", perhaps that's setup for PRs into polkadot-js/apps instead of our fork of it, so it may not matter if it doesn't pass until we change the PR target to polkadot-js/apps instead |
2 participants
Requires DataHighway-DHX/node#201