Skip to content

feat(trace-protobuf): Add two fields to ClientGroupedStats#1630

Draft
lym953 wants to merge 8 commits intomainfrom
yiming.luo/span-tag-field
Draft

feat(trace-protobuf): Add two fields to ClientGroupedStats#1630
lym953 wants to merge 8 commits intomainfrom
yiming.luo/span-tag-field

Conversation

@lym953
Copy link
Contributor

@lym953 lym953 commented Feb 25, 2026

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@github-actions
Copy link

github-actions bot commented Feb 25, 2026 •
edited
Loading

📚 Documentation Check Results

⚠️ 576 documentation warning(s) found

📦 libdd-trace-protobuf - 97 warning(s)

📦 libdd-trace-stats - 479 warning(s)

Updated: 2026-02-25 22:00:56 UTC | Commit: 079d89d | missing-docs job results

@github-actions
Copy link

github-actions bot commented Feb 25, 2026 •
edited
Loading

🔒 Cargo Deny Results

✅ No issues found!

📦 libdd-trace-protobuf - ✅ No issues

📦 libdd-trace-stats - ✅ No issues

Updated: 2026-02-25 22:00:16 UTC | Commit: 079d89d | dependency-check job results

@pr-commenter
Copy link

pr-commenter bot commented Feb 25, 2026 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2026-02-25 23:18:11

Comparing candidate commit c2fe7cb in PR branch yiming.luo/span-tag-field with baseline commit 40898a4 in branch main.

Found 6 performance improvements and 6 performance regressions! Performance is the same for 45 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

  • 🟥 execution_time [+12.071ms; +12.774ms] or [+25.145%; +26.609%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟥 execution_time [+4.003µs; +4.183µs] or [+5.653%; +5.907%]
  • 🟥 throughput [-790393.737op/s; -754960.801op/s] or [-5.597%; -5.346%]

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+4.189µs; +4.363µs] or [+6.179%; +6.436%]
  • 🟥 throughput [-895186.716op/s; -857663.613op/s] or [-6.068%; -5.813%]

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

  • 🟩 execution_time [-39.523µs; -39.125µs] or [-7.380%; -7.306%]
  • 🟩 throughput [+147279.047op/s; +148694.268op/s] or [+7.887%; +7.963%]

scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters

  • 🟩 execution_time [-20.010µs; -19.888µs] or [-10.537%; -10.473%]
  • 🟩 throughput [+616370.168op/s; +619823.160op/s] or [+11.705%; +11.770%]

scenario:profile_add_sample2_frames_x1000

  • 🟩 execution_time [-193.682µs; -193.395µs] or [-26.929%; -26.890%]

scenario:profile_add_sample_frames_x1000

  • 🟩 execution_time [-336.142µs; -333.154µs] or [-7.888%; -7.818%]

scenario:tags/replace_trace_tags

  • 🟥 execution_time [+97.796ns; +104.917ns] or [+4.122%; +4.422%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 186.515µs 187.367µs ± 0.767µs 187.014µs ± 0.225µs 187.983µs 189.253µs 189.557µs 190.349µs 1.78% 1.465 1.486 0.41% 0.054µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5253515.620op/s 5337204.246op/s ± 21725.998op/s 5347200.764op/s ± 6438.567op/s 5351857.897op/s 5356485.384op/s 5358541.606op/s 5361490.451op/s 0.27% -1.449 1.417 0.41% 1536.260op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.550µs 17.666µs ± 0.061µs 17.658µs ± 0.031µs 17.695µs 17.741µs 17.792µs 18.263µs 3.42% 4.815 44.893 0.34% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54755316.741op/s 56606640.350op/s ± 191669.336op/s 56629978.306op/s ± 98016.197op/s 56698643.585op/s 56837194.829op/s 56895620.478op/s 56981193.357op/s 0.62% -4.577 41.867 0.34% 13553.069op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.105µs 10.187µs ± 0.038µs 10.184µs ± 0.032µs 10.216µs 10.249µs 10.278µs 10.286µs 0.99% 0.210 -0.722 0.37% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 97222457.504op/s 98170257.888op/s ± 366411.056op/s 98189811.323op/s ± 304543.955op/s 98489675.865op/s 98692544.526op/s 98883752.287op/s 98963581.402op/s 0.79% -0.196 -0.733 0.37% 25909.174op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [187.261µs; 187.473µs] or [-0.057%; +0.057%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5334193.231op/s; 5340215.260op/s] or [-0.056%; +0.056%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.658µs; 17.674µs] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [56580076.823op/s; 56633203.876op/s] or [-0.047%; +0.047%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.181µs; 10.192µs] or [-0.052%; +0.052%] None None None
normalization/normalize_name/normalize_name/good throughput [98119476.840op/s; 98221038.936op/s] or [-0.052%; +0.052%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.225µs 3.219µs ± 1.443µs 3.012µs ± 0.025µs 3.037µs 3.691µs 13.967µs 14.983µs 397.38% 7.413 55.874 44.72% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.019µs; 3.419µs] or [-6.213%; +6.213%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.444µs 2.474µs ± 0.019µs 2.469µs ± 0.006µs 2.475µs 2.530µs 2.534µs 2.545µs 3.05% 2.311 4.935 0.76% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.471µs; 2.477µs] or [-0.105%; +0.105%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 495.341µs 496.184µs ± 0.548µs 496.097µs ± 0.239µs 496.385µs 496.913µs 497.222µs 501.810µs 1.15% 5.638 54.044 0.11% 0.039µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1992785.894op/s 2015383.413op/s ± 2210.561op/s 2015733.020op/s ± 969.407op/s 2016569.253op/s 2017592.261op/s 2018022.213op/s 2018811.057op/s 0.15% -5.558 52.940 0.11% 156.310op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 371.314µs 371.976µs ± 0.304µs 371.961µs ± 0.190µs 372.141µs 372.513µs 372.715µs 373.012µs 0.28% 0.462 0.306 0.08% 0.022µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2680881.399op/s 2688347.183op/s ± 2197.351op/s 2688455.625op/s ± 1371.248op/s 2689838.416op/s 2691636.597op/s 2692891.619op/s 2693136.530op/s 0.17% -0.457 0.299 0.08% 155.376op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 169.528µs 169.951µs ± 0.167µs 169.943µs ± 0.080µs 170.030µs 170.197µs 170.367µs 170.871µs 0.55% 0.760 4.269 0.10% 0.012µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5852369.754op/s 5884049.757op/s ± 5783.460op/s 5884316.661op/s ± 2762.366op/s 5886830.677op/s 5893686.601op/s 5897737.597op/s 5898722.501op/s 0.24% -0.743 4.196 0.10% 408.952op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.263µs 37.395µs ± 0.045µs 37.394µs ± 0.031µs 37.424µs 37.469µs 37.500µs 37.507µs 0.30% 0.210 -0.273 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26661819.063op/s 26741331.232op/s ± 32094.317op/s 26742245.114op/s ± 22365.972op/s 26764884.602op/s 26788808.698op/s 26798622.394op/s 26836328.647op/s 0.35% -0.204 -0.273 0.12% 2269.411op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.133µs 46.277µs ± 0.059µs 46.271µs ± 0.047µs 46.321µs 46.374µs 46.408µs 46.414µs 0.31% 0.202 -0.710 0.13% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21545358.192op/s 21609165.464op/s ± 27343.376op/s 21611951.828op/s ± 22000.488op/s 21632200.721op/s 21646801.867op/s 21663258.796op/s 21676346.049op/s 0.30% -0.198 -0.712 0.13% 1933.469op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [496.108µs; 496.260µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [2015077.051op/s; 2015689.776op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [371.934µs; 372.018µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2688042.651op/s; 2688651.714op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [169.928µs; 169.974µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5883248.225op/s; 5884851.289op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.389µs; 37.402µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26736883.268op/s; 26745779.195op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.269µs; 46.285µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21605375.935op/s; 21612954.993op/s] or [-0.018%; +0.018%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.942µs 4.990µs ± 0.027µs 4.986µs ± 0.028µs 5.016µs 5.025µs 5.028µs 5.031µs 0.90% -0.264 -1.323 0.54% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [4.987µs; 4.994µs] or [-0.075%; +0.075%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 3.919ms 3.927ms ± 0.008ms 3.926ms ± 0.002ms 3.927ms 3.934ms 3.948ms 4.014ms 2.25% 8.190 87.530 0.19% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [3.926ms; 3.928ms] or [-0.027%; +0.027%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.859µs 25.367µs ± 9.542µs 18.149µs ± 0.140µs 34.437µs 43.490µs 45.328µs 67.017µs 269.25% 1.027 0.587 37.52% 0.675µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.044µs; 26.689µs] or [-5.213%; +5.213%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 242.108ns 252.809ns ± 12.227ns 247.565ns ± 3.313ns 254.732ns 282.481ns 289.578ns 291.097ns 17.58% 1.660 1.677 4.82% 0.865ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [251.114ns; 254.503ns] or [-0.670%; +0.670%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.544µs 89.785µs ± 0.226µs 89.767µs ± 0.041µs 89.811µs 89.891µs 90.269µs 92.678µs 3.24% 10.767 134.138 0.25% 0.016µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [89.754µs; 89.816µs] or [-0.035%; +0.035%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 59.947ms 60.427ms ± 2.240ms 60.121ms ± 0.075ms 60.203ms 60.505ms 70.758ms 82.650ms 37.47% 8.688 76.724 3.70% 0.158ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.117ms; 60.738ms] or [-0.514%; +0.514%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 161.241µs 162.062µs ± 0.501µs 161.987µs ± 0.170µs 162.188µs 162.638µs 163.416µs 166.871µs 3.01% 5.519 45.451 0.31% 0.035µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.993µs; 162.132µs] or [-0.043%; +0.043%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.606ms 10.634ms ± 0.016ms 10.631ms ± 0.008ms 10.640ms 10.664ms 10.679ms 10.733ms 0.95% 1.636 6.085 0.15% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.632ms; 10.636ms] or [-0.021%; +0.021%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.751ms 14.811ms ± 0.046ms 14.806ms ± 0.019ms 14.821ms 14.899ms 14.968ms 15.123ms 2.14% 3.368 17.587 0.31% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.804ms; 14.817ms] or [-0.043%; +0.043%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.552µs 146.414µs ± 1.537µs 146.163µs ± 0.506µs 146.741µs 148.101µs 151.606µs 160.881µs 10.07% 5.373 42.468 1.05% 0.109µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.201µs; 146.627µs] or [-0.145%; +0.145%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 525.101µs 525.679µs ± 0.686µs 525.572µs ± 0.160µs 525.761µs 526.087µs 530.317µs 531.238µs 1.08% 5.977 40.648 0.13% 0.049µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [525.584µs; 525.774µs] or [-0.018%; +0.018%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.911µs ± 0.002µs 3.911µs ± 0.001µs 3.912µs 3.914µs 3.917µs 3.917µs 0.17% -1.663 15.003 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 255280854.365op/s 255704850.632op/s ± 149251.901op/s 255706264.809op/s ± 79412.432op/s 255786174.385op/s 255887112.335op/s 255955955.446op/s 256828246.487op/s 0.44% 1.688 15.203 0.06% 10553.703op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.045µs 80.337µs ± 0.602µs 80.315µs ± 0.394µs 80.704µs 81.305µs 81.801µs 82.240µs 2.40% 0.164 -0.004 0.75% 0.043µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12159459.147op/s 12448261.727op/s ± 93188.504op/s 12450929.281op/s ± 61030.310op/s 12512436.148op/s 12609706.923op/s 12639991.371op/s 12650948.000op/s 1.61% -0.120 -0.046 0.75% 6589.422op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 74.429µs 74.906µs ± 0.158µs 74.910µs ± 0.078µs 74.988µs 75.141µs 75.306µs 75.612µs 0.94% 0.183 2.670 0.21% 0.011µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13225383.933op/s 13350041.189op/s ± 28100.619op/s 13349264.120op/s ± 13817.376op/s 13363149.779op/s 13398674.584op/s 13431529.691op/s 13435694.610op/s 0.65% -0.154 2.622 0.21% 1987.014op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.899µs 3.912µs ± 0.002µs 3.912µs ± 0.002µs 3.913µs 3.915µs 3.917µs 3.918µs 0.17% -0.483 2.316 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255224590.150op/s 255644319.364op/s ± 159859.148op/s 255654070.842op/s ± 114058.854op/s 255755729.667op/s 255868367.541op/s 255918126.713op/s 256469276.967op/s 0.32% 0.491 2.351 0.06% 11303.749op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 71.699µs 72.064µs ± 0.150µs 72.053µs ± 0.080µs 72.135µs 72.326µs 72.469µs 72.584µs 0.74% 0.357 0.613 0.21% 0.011µs 1 200
credit_card/is_card_number/378282246310005 throughput 13777060.402op/s 13876656.797op/s ± 28822.433op/s 13878648.394op/s ± 15436.669op/s 13893979.046op/s 13919760.214op/s 13941668.431op/s 13947148.335op/s 0.49% -0.342 0.597 0.21% 2038.054op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.149µs 52.208µs ± 0.033µs 52.203µs ± 0.018µs 52.224µs 52.264µs 52.320µs 52.392µs 0.36% 1.551 5.269 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19086830.365op/s 19154307.926op/s ± 12064.444op/s 19156102.833op/s ± 6679.333op/s 19162366.071op/s 19170834.165op/s 19174863.920op/s 19175849.935op/s 0.10% -1.541 5.216 0.06% 853.085op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.721µs 5.910µs ± 0.054µs 5.910µs ± 0.043µs 5.957µs 5.996µs 6.022µs 6.042µs 2.24% -0.151 0.018 0.91% 0.004µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165497014.154op/s 169208378.823op/s ± 1547159.315op/s 169201140.718op/s ± 1237836.874op/s 170406519.655op/s 171676013.170op/s 172614251.851op/s 174805765.055op/s 3.31% 0.206 0.098 0.91% 109400.684op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.892µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.913µs 3.917µs 3.920µs 3.924µs 0.30% -0.673 10.763 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254865112.863op/s 255624941.287op/s ± 193025.746op/s 255636448.796op/s ± 98599.693op/s 255732113.571op/s 255853638.833op/s 255914587.234op/s 256929149.049op/s 0.51% 0.701 10.916 0.08% 13648.981op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.011µs 64.292µs ± 0.124µs 64.273µs ± 0.043µs 64.313µs 64.553µs 64.759µs 64.959µs 1.07% 2.313 7.416 0.19% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15394422.877op/s 15554003.877op/s ± 29751.873op/s 15558517.882op/s ± 10403.487op/s 15570284.501op/s 15585923.651op/s 15595741.874op/s 15622436.944op/s 0.41% -2.290 7.295 0.19% 2103.775op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.381µs 57.502µs ± 0.090µs 57.482µs ± 0.051µs 57.546µs 57.686µs 57.724µs 57.856µs 0.65% 1.239 1.468 0.16% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17284365.864op/s 17390643.022op/s ± 27282.086op/s 17396754.638op/s ± 15532.343op/s 17410846.958op/s 17421727.246op/s 17426268.601op/s 17427306.847op/s 0.18% -1.230 1.432 0.16% 1929.135op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.893µs 3.911µs ± 0.003µs 3.911µs ± 0.001µs 3.912µs 3.915µs 3.918µs 3.921µs 0.25% -2.134 18.209 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255050971.792op/s 255688615.498op/s ± 170752.599op/s 255686640.376op/s ± 64221.775op/s 255756490.239op/s 255858515.948op/s 255948040.102op/s 256879823.341op/s 0.47% 2.166 18.399 0.07% 12074.032op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.570µs 54.780µs ± 0.165µs 54.744µs ± 0.073µs 54.830µs 55.094µs 55.390µs 55.483µs 1.35% 1.976 4.540 0.30% 0.012µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 18023418.034op/s 18254926.762op/s ± 54588.821op/s 18266691.601op/s ± 24368.643op/s 18289772.822op/s 18312093.490op/s 18322889.155op/s 18325052.179op/s 0.32% -1.953 4.432 0.30% 3860.013op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.139µs 52.210µs ± 0.035µs 52.205µs ± 0.021µs 52.227µs 52.275µs 52.301µs 52.302µs 0.19% 0.656 0.023 0.07% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19119672.520op/s 19153315.695op/s ± 12679.682op/s 19155193.130op/s ± 7589.871op/s 19162223.593op/s 19171434.851op/s 19174564.921op/s 19179422.398op/s 0.13% -0.653 0.018 0.07% 896.589op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.796µs 5.908µs ± 0.047µs 5.907µs ± 0.029µs 5.936µs 5.985µs 6.006µs 6.014µs 1.81% -0.110 -0.427 0.79% 0.003µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 166275006.479op/s 169265347.129op/s ± 1343813.426op/s 169280273.608op/s ± 844892.572op/s 170310098.257op/s 171595771.912op/s 172486371.637op/s 172541067.986op/s 1.93% 0.148 -0.415 0.79% 95021.959op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.910µs; 3.911µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ throughput [255684165.754op/s; 255725535.510op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [80.254µs; 80.420µs] or [-0.104%; +0.104%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12435346.697op/s; 12461176.757op/s] or [-0.104%; +0.104%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [74.885µs; 74.928µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13346146.714op/s; 13353935.665op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [255622164.423op/s; 255666474.304op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [72.043µs; 72.085µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/378282246310005 throughput [13872662.285op/s; 13880651.309op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.203µs; 52.212µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19152635.910op/s; 19155979.942op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.903µs; 5.918µs] or [-0.127%; +0.127%] None None None
credit_card/is_card_number/x371413321323331 throughput [168993957.422op/s; 169422800.224op/s] or [-0.127%; +0.127%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255598189.775op/s; 255651692.799op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.275µs; 64.309µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15549880.554op/s; 15558127.201op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.490µs; 57.515µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17386861.988op/s; 17394424.057op/s] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.911µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255664950.830op/s; 255712280.166op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.757µs; 54.803µs] or [-0.042%; +0.042%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18247361.276op/s; 18262492.247op/s] or [-0.041%; +0.041%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.206µs; 52.215µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19151558.413op/s; 19155072.977op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.902µs; 5.915µs] or [-0.110%; +0.110%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [169079107.512op/s; 169451586.745op/s] or [-0.110%; +0.110%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.915µs 34.329µs ± 0.744µs 33.991µs ± 0.038µs 34.059µs 35.875µs 35.961µs 37.731µs 11.00% 1.888 2.324 2.16% 0.053µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.226µs; 34.432µs] or [-0.300%; +0.300%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 187.701ns 190.414ns ± 1.888ns 190.281ns ± 1.459ns 191.631ns 193.593ns 196.187ns 197.321ns 3.70% 0.648 0.347 0.99% 0.134ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [190.153ns; 190.676ns] or [-0.137%; +0.137%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c2fe7cb 1772060481 yiming.luo/span-tag-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 9.530ms 9.803ms ± 0.068ms 9.811ms ± 0.028ms 9.838ms 9.889ms 9.980ms 10.021ms 2.14% -0.737 2.548 0.70% 0.005ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [9.794ms; 9.813ms] or [-0.097%; +0.097%] None None None

Baseline

Omitted due to size.

@dd-octo-sts
Copy link
Contributor

dd-octo-sts bot commented Feb 25, 2026 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.57 MB 7.57 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 87.79 MB 87.79 MB +0% (+1.78 KB) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 101.51 MB 101.52 MB +0% (+2.17 KB) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.71 MB 9.71 MB +0% (+48 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 20.43 MB 20.44 MB +0% (+1.00 KB) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 73.49 KB 73.49 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 151.28 MB 151.27 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 817.72 MB 817.73 MB +0% (+13.24 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 6.51 MB 6.51 MB +0% (+512 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 73.49 KB 73.49 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 20.14 MB 20.14 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 39.51 MB 39.51 MB +0% (+1.08 KB) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 17.43 MB 17.43 MB +0% (+1.00 KB) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 74.62 KB 74.62 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 154.16 MB 154.16 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 805.51 MB 805.52 MB +0% (+12.19 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 5.01 MB 5.01 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 74.62 KB 74.62 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 21.46 MB 21.46 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 37.29 MB 37.29 MB +0% (+1.08 KB) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 76.06 MB 76.06 MB +0% (+1.46 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.00 MB 9.00 MB +.04% (+4.00 KB) 🔍
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 95.61 MB 95.61 MB +0% (+2.16 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.45 MB 10.45 MB 0% (0 B) 👌

@lym953 lym953 force-pushed the yiming.luo/span-tag-field branch from 7c941c6 to fb53fc8 Compare February 25, 2026 19:45
@github-actions
Copy link

github-actions bot commented Feb 25, 2026 •
edited
Loading

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/yiming.luo/span-tag-field

Summary by Rule

Rule Base Branch PR Branch Change

Annotation Counts by File

File Base Branch PR Branch Change

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 0 ✅ -5 (-100.0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 27 27 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 59 62 ⚠️ +3 (+5.1%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-crashtracker 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 9 9 No change (0%)
libdd-trace-utils 15 17 ⚠️ +2 (+13.3%)
Total 219 219 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@lym953 @claude
fix(trace-protobuf): Sync stats.proto with datadog-agent and update p…
2e6371a 
…b.rs

- Align stats.proto with datadog-agent (use @inject_tag comment instead of
  gogoproto annotation, remove gogo.proto import, update field comments)
- Update DATADOG_AGENT_TAG to bdcdd8cf1ba4090a29b96d5669cfab5dd81814b1
- Regenerate pb.rs with service_source and span_derived_primary_tags fields
- Add serde(default) attributes for new fields in build.rs
- Fix pb_test.rs to include new fields in ClientGroupedStats initializer

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lym953 and others added 5 commits February 25, 2026 16:39
@lym953 @claude
fix(trace-stats): Add new ClientGroupedStats fields in encode_grouped…
e91e30f 
…_stats

Add service_source and span_derived_primary_tags to the ClientGroupedStats
initializer in aggregation.rs following the addition of these fields to
the protobuf definition.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@lym953 @claude
fix(bin-tests): Fix function-casts-as-integer clippy lint
8e17676 
Add intermediate *const () pointer cast before usize cast for signal
handler function pointers, as required by the function_casts_as_integer
clippy lint.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@lym953 @claude
fix(sidecar): Fix unnecessary_unwrap clippy lint in appsec_config han…
8282e1c 
…dling

Replace is_some() + unwrap() pattern with idiomatic if let Some(...) in
config.rs and entry.rs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@lym953 @claude
fix(trace-utils): Add new ClientGroupedStats fields in stats_utils test
b0aaac7 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@lym953 @claude
fix(bin-tests): Fix remaining function-casts-as-integer lint in behav…
c2fe7cb 
…ior.rs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci-build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lym953