chore(profiling): try fixing tls feature conflict#1622
chore(profiling): try fixing tls feature conflict#1622
Conversation
ProfileExporter::new() initializes TLS on every call, which on Linux involves expensive disk I/O to load the system certificate store. Add TlsConfig (wrapping rustls::ClientConfig with the platform verifier) and ProfileExporter::new_with_tls() so callers can initialize TLS once and reuse it across exporter instances. FFI: adds ddog_prof_TlsConfig_new, TlsConfig_try_clone, TlsConfig_drop, and Exporter_new_with_tls via ArcHandle<TlsConfig> for shared ownership. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
📚 Documentation Check Results📦
|
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
🔒 Cargo Deny Results📦
|
BenchmarksComparisonBenchmark execution time: 2026-02-23 15:30:51 Comparing candidate commit 04b7b3b in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/378282246310005
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
==========================================
- Coverage 71.24% 71.17% -0.08%
==========================================
Files 423 424 +1
Lines 62198 62558 +360
==========================================
+ Hits 44315 44523 +208
- Misses 17883 18035 +152
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.