Create / Save snapshots of programming questions on edit by adi-herwana-nus · Pull Request #8022 · Coursemology/coursemology2

adi-herwana-nus · 2025-07-18T02:43:54Z

No description provided.

…to gradings

hound · 2025-07-18T02:44:05Z

app/models/course/assessment/question/voice_response.rb

 class Course::Assessment::Question::VoiceResponse < ApplicationRecord
  acts_as :question, class_name: 'Course::Assessment::Question'

+  def is_saving_snapshots?


Naming/PredicateName: Rename is_saving_snapshots? to saving_snapshots?.

hound · 2025-07-18T02:44:05Z

app/controllers/course/assessment/question/programming_controller.rb

+                OR course_assessment_answer_programming_auto_gradings.question_snapshot_id = #{@programming_question.id})
+        SQL
+        )
+


[Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.

hound · 2025-07-18T02:44:05Z

app/controllers/course/assessment/question/programming_controller.rb

+            AND (course_assessment_answer_programming_auto_gradings.question_snapshot_id IS NULL
+                OR course_assessment_answer_programming_auto_gradings.question_snapshot_id = #{@programming_question.id})
+        SQL
+        )


[Correctable] Layout/ClosingParenthesisIndentation: Align ) with (.

hound · 2025-07-18T02:44:05Z

app/controllers/course/assessment/question/programming_controller.rb

+        snapshot.skip_process_package = true
+        snapshot.save!
+
+        update_result = ActiveRecord::Base.connection.execute(<<-SQL.squish


Lint/UselessAssignment: Useless assignment to variable - update_result. Did you mean update_timestamp?

hound · 2025-07-18T02:44:05Z

app/controllers/course/assessment/question/programming_controller.rb


  def update
    result = @programming_question.class.transaction do
+      old_update_timestamp = @programming_question.snapshot_of_state_at


Lint/UselessAssignment: Useless assignment to variable - old_update_timestamp. Did you mean update_timestamp?

hound · 2025-07-18T02:44:06Z

app/models/course/assessment/question/programming.rb

  end
+
+  def destroy_snapshots
+    self.snapshots.where.not(id: self).destroy_all


[Correctable] Style/RedundantSelf: Redundant self detected.

hound · 2025-07-18T02:44:06Z

app/models/course/assessment/question/programming.rb

+    !skip_process_package?
+  end
+
+  def is_saving_snapshots?


Naming/PredicateName: Rename is_saving_snapshots? to saving_snapshots?.

hound · 2025-07-18T02:44:06Z

app/models/course/assessment/question/rubric_based_response.rb

    self.categories = duplicator.duplicate(other.categories)
  end

+  def is_saving_snapshots?


Naming/PredicateName: Rename is_saving_snapshots? to saving_snapshots?.

hound · 2025-07-18T02:44:06Z

app/models/course/assessment/question/scribing.rb

  acts_as :question, class_name: 'Course::Assessment::Question'
  has_one_attachment

+  def is_saving_snapshots?


Naming/PredicateName: Rename is_saving_snapshots? to saving_snapshots?.

hound · 2025-07-18T02:44:06Z

app/models/course/assessment/question/text_response.rb


  accepts_nested_attributes_for :groups, allow_destroy: true

+  def is_saving_snapshots?


Naming/PredicateName: Rename is_saving_snapshots? to saving_snapshots?.

hound · 2025-07-27T17:09:38Z

app/helpers/course/assessment/answer/programming_test_case_helper.rb

-      end
-    end
+  def get_first_test_failures_by_type(test_cases_by_type, test_results_by_type)
+    test_cases_by_type.entries.map do |test_case_type, test_cases|


[Correctable] Style/HashTransformValues: Prefer transform_values over map {...}.to_h.

hound · 2025-07-27T17:09:38Z

app/services/course/assessment/answer/auto_grading_service.rb

  # subclasses.
  #
  # @param [Course::Assessment::Answer] answer The answer to be evaluated.
+    # @param [Course::Assessment::Answer::AutoGrading] auto_grading The auto grading object that will store the results.


[Correctable] Layout/CommentIndentation: Incorrect indentation detected (column 4 instead of 2).

hound · 2025-07-27T17:09:38Z

app/services/course/assessment/answer/auto_grading_service.rb

  # and makes sure answer is in the correct state.
  #
  # @param [Course::Assessment::Answer] answer The answer to be graded.
+    # @param [Course::Assessment::Answer::AutoGrading] auto_grading The auto grading object that will store the results.


[Correctable] Layout/CommentIndentation: Incorrect indentation detected (column 4 instead of 2).

hound · 2025-07-27T17:09:38Z

app/services/course/assessment/answer/programming_auto_grading_service.rb

+    # our original question by comparing the updated_at timestamps.
+    programming_auto_grading.question_snapshot_id = 
+      Course::Assessment::Question::Programming.
+        where(current_id: question.id, snapshot_index: question.snapshot_index).first&.id || question.id


[Correctable] Layout/MultilineMethodCallIndentation: Align where with Course::Assessment::Question::Programming. on line 14.

hound · 2025-07-27T17:09:38Z

app/services/course/assessment/answer/programming_auto_grading_service.rb

+
+    # If the question was updated during the evaluation, we can still find
+    # our original question by comparing the updated_at timestamps.
+    programming_auto_grading.question_snapshot_id = 


[Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.

hound · 2025-07-27T17:09:39Z

app/services/course/assessment/question/answers_evaluation_service.rb

+      # For now, we have to manually query the latest_answer_ids first.
+      latest_answer_ids = @question.answers.
+        unscope(:order).
+        select('DISTINCT ON (submission_id) id').


[Correctable] Layout/MultilineMethodCallIndentation: Align select with @question.answers. on line 16.

hound · 2025-07-27T17:09:39Z

app/services/course/assessment/question/answers_evaluation_service.rb

+      # In Rails 8, it will be possible to override the batch ordering using :cursor.
+      # For now, we have to manually query the latest_answer_ids first.
+      latest_answer_ids = @question.answers.
+        unscope(:order).


[Correctable] Layout/MultilineMethodCallIndentation: Align unscope with @question.answers. on line 16.

hound · 2025-07-27T17:09:39Z

app/views/course/assessment/answer/programming/_auto_grading.jbuilder

+  end
+end
+
+json.(auto_grading, :stdout, :stderr) if show_stdout_and_stderr


[Correctable] Style/LambdaCall: Prefer the use of lambda.call(...) over lambda.(...).

hound · 2025-07-27T17:09:39Z

app/views/course/assessment/answer/programming/_programming.json.jbuilder

-      end
+    elsif first_failures_by_type['private_test']
+      explanations << format_ckeditor_rich_text(get_hint(
+        first_failures_by_type['private_test'],


[Correctable] Layout/FirstArgumentIndentation: Indent the first argument one step more than get_hint(.

hound · 2025-07-27T17:09:39Z

app/views/course/assessment/answer/programming/_programming.json.jbuilder

-      end
+    if first_failures_by_type['public_test']
+      explanations << format_ckeditor_rich_text(get_hint(
+        first_failures_by_type['public_test'],


[Correctable] Layout/FirstArgumentIndentation: Indent the first argument one step more than get_hint(.

adi-herwana-nus added 3 commits July 9, 2025 18:38

feat(programming): Implement programming question snapshotting

21ed15d

feat(programming): reinterpret auto_grading as many-to-one with answer

61c7749

feat(programming): change programming view/apis to return historic au…

71603a0

…to gradings

adi-herwana-nus requested a review from cysjonathan July 18, 2025 02:43

hound bot reviewed Jul 18, 2025

View reviewed changes

feat(programming): separate test cases and results in output

c5a25a2

hound bot reviewed Jul 27, 2025

View reviewed changes


		accepts_nested_attributes_for :groups, allow_destroy: true

		def is_saving_snapshots?

Conversation

adi-herwana-nus commented Jul 18, 2025

Uh oh!

hound bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

hound bot Jul 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant