FE optimization: lazy load page/question components; ckeditor; improve css compilation#7932
Merged
adi-herwana-nus merged 5 commits intomasterfrom May 19, 2025
Merged
Conversation
- manually assign chunk names to each route component - removed old renaming logic (caused ENAMETOOLONG error)
9a671c1 to
d8cc2c6
Compare
pchunky
approved these changes
May 19, 2025
Contributor
pchunky
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this! If there are any issues in production, we can always patch them later.
Saw you added the answer adapter for rubric-based response, too. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains changes cherry-picked from #7889; continuation of #7928
Commits already merged: 17 / 36
Commits included in this PR: 7 / 36
Commits to reject: 1 / 36
Commits remaining: 11 / 36