FE optimization: lazy load jquery, ace; trim moment to >= 2014#7924
FE optimization: lazy load jquery, ace; trim moment to >= 2014#7924cysjonathan merged 4 commits intomasterfrom
Conversation
- remove jQuery check from `wait_for_ajax` rspec helper - lazy load jQuery, jQuery UI for achievement reordering page - lazy load non-python language modes and removed jquery initializer
ba312d4 to
e6a6423
Compare
|
I considered that too. In fact, I tried removing the jQuery dependency completely but that meant rewriting the table since reordering with @hello-pangea/dnd will break Having the reordering available without switching is okay too if we remove jQuery. I didn't do that because I didn't want jQuery loading to bog down the page if someone comes in just to change one achievement's title. The point with my changes to jQuery in the original PR is to reinforce that jQuery is only needed by the Achievements page. Previously, everyone thinks that it's still used somewhere by something somehow, carried over from when we SSR with Rails. Now, it's localised. |

Contains changes cherry-picked from #7889 (7 of 36 commits)