Closed
Conversation
docs-spelling-check/styles/config/vocabularies/Consensys-common/accept.txt
Outdated
Show resolved
Hide resolved
| Microsoft.GeneralURL = NO | ||
|
|
||
| # Allow "agent" variants despite Microsoft.Terms preference | ||
| Microsoft.Terms.Ignore = (?i)\bagents?\b |
There was a problem hiding this comment.
Microsoft.Terms.Ignore may not be valid Vale config
Medium Severity
Microsoft.Terms.Ignore does not appear to be a documented Vale configuration key. The .Ignore suffix is supported for the built-in Spelling rule (to reference dictionary files), but Microsoft.Terms is a substitution-type rule which only supports exceptions and vocab in its YAML definition. Vale will likely silently ignore this setting, meaning "agent" variants won't actually be excluded from Microsoft.Terms checks. The vocabulary accept.txt or the rule's exceptions array would be the standard way to achieve this.
| - Ethers.js | ||
| - EthSigner | ||
| - EVM | ||
| - Embedded Wallets |
There was a problem hiding this comment.
Contributor
Author
|
closing this in favor of #98 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Low Risk
CI/docs-lint configuration changes only; primary risk is introducing false positives/negatives in spelling checks or minor workflow execution issues.
Overview
Adds a new GitHub Actions workflow (
.github/workflows/spelling.yml) that runs the localdocs-spelling-checkcomposite action (Vale) on pull requests and pushes tomain.Tunes Vale rules to reduce noise: ignores Microsoft’s
agent(s)terminology preference, adds heading/vocabulary exceptions (e.g.,Embedded Wallets,inviter,pimlico,viem), removes the localMicrosoft/Veryrule file, and updates.gitignoreto avoid committing synced style packages while properly ignoring.idea.Written by Cursor Bugbot for commit 94cf93f. This will update automatically on new commits. Configure here.