Skip to content

Comments

coated textures in snow area only#288

Open
Noa3 wants to merge 3 commits intoComplementaryDevelopment:mainfrom
Noa3:DustyEffectInSnowArea
Open

coated textures in snow area only#288
Noa3 wants to merge 3 commits intoComplementaryDevelopment:mainfrom
Noa3:DustyEffectInSnowArea

Conversation

@Noa3
Copy link

@Noa3 Noa3 commented Feb 19, 2026

Add snow-only mode for coated textures

Adds COATED_TEXTURES_SNOW_ONLY option that restricts coated texture overlay to snowy biomes, using the existing inSnowy uniform for smooth biome-based transitions.

  • shaders/lib/common.glsl: New //#define COATED_TEXTURES_SNOW_ONLY (off by default)
  • shaders/lib/materials/materialMethods/coatedTextures.glsl: Early-out and noiseFactor scaling gated on inSnowy:
    #ifdef COATED_TEXTURES_SNOW_ONLY
        if (inSnowy < 0.001) return;
        noiseFactor *= inSnowy;
    #endif
  • shaders/shaders.properties: Added to IPBR_SETTINGS menu alongside COATED_TEXTURES
  • shaders/lang/en_US.lang: Option label and tooltip

Copilot AI and others added 3 commits February 19, 2026 06:23
Co-authored-by: Noa3 <8495084+Noa3@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 19, 2026 10:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an optional “snow-only” mode for coated texture overlays, limiting the effect to snowy biomes via the existing inSnowy uniform (with smooth transitions).

Changes:

  • Introduces COATED_TEXTURES_SNOW_ONLY (off by default) as a new shader define.
  • Gates coated texture application (early-out + intensity scaling) based on inSnowy.
  • Exposes the toggle in the shader options UI and adds English label/tooltip text.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
shaders/shaders.properties Adds COATED_TEXTURES_SNOW_ONLY to the IPBR settings menu so users can toggle it.
shaders/lib/materials/materialMethods/coatedTextures.glsl Applies snow-only gating using inSnowy (early return + noiseFactor scaling).
shaders/lib/common.glsl Declares the new optional define (commented out by default).
shaders/lang/en_US.lang Adds user-facing option label and tooltip for the new toggle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

option.COATED_TEXTURES.comment=Adds auto-generated dusty details to textures. §e[*]§r RP Support option must be set to Integrated PBR+.

option.COATED_TEXTURES_SNOW_ONLY=Snow Only Coating
option.COATED_TEXTURES_SNOW_ONLY.comment=When enabled, coated textures only appear in snowy biomes or areas with snowfall. §e[*]§r Requires Coated Textures to be enabled.
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltip says “snowy biomes or areas with snowfall”, but the implementation uses the inSnowy uniform which is derived from biome_precipitation == 2 (snow precipitation type). That corresponds to snowy biomes, not necessarily places where it is currently snowing / can snow due to local temperature/altitude. Consider rewording the tooltip to match the actual behavior (e.g., “biomes with snow precipitation”).

Suggested change
option.COATED_TEXTURES_SNOW_ONLY.comment=When enabled, coated textures only appear in snowy biomes or areas with snowfall. §e[*]§r Requires Coated Textures to be enabled.
option.COATED_TEXTURES_SNOW_ONLY.comment=When enabled, coated textures only appear in biomes with snow precipitation. §e[*]§r Requires Coated Textures to be enabled.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants