Skip to content

WriteMetadata(): Remove msLevels retrieval out of the for loop #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caetera merged 2 commits into from
Jan 6, 2026
Merged

WriteMetadata(): Remove msLevels retrieval out of the for loop #201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74d4d5b
Remove msLevels retrival out of the for loop; Raw file wont change in…
lzivadinovic Jan 6, 2026
e450deb
Fix typo
lzivadinovic Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Writer/MetadataWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ public void WriteMetadata(IRawDataPlus rawFile, int firstScanNumber, int lastSca
{
if(rawFile.SelectMsData())
{
// Get MS levels
msLevels = WriterUtil.CountScanOrder(rawFile);

for (var scanNumber = firstScanNumber; scanNumber <= lastScanNumber; scanNumber++)
{
var time = rawFile.RetentionTimeFromScanNumber(scanNumber);
Expand All @@ -57,9 +60,6 @@ public void WriteMetadata(IRawDataPlus rawFile, int firstScanNumber, int lastSca
// Get the scan event for this scan number
var scanEvent = rawFile.GetScanEventForScanNumber(scanNumber);

// Get MS levels
msLevels = WriterUtil.CountScanOrder(rawFile);

if (time > maxTime)
maxTime = time;
if (time < minTime)
Expand Down Expand Up @@ -174,10 +174,10 @@ private void WriteJsonMetada(IRawDataPlus rawFile, int firstScanNumber, int last
metadata.addMSData(new CVTerm("PRIDE:0000481", "PRIDE", "Number of MS1 spectra",
msLevels[MSOrderType.Ms].ToString()));
if (msLevels[MSOrderType.Ms2] > 0)
metadata.addMSData(new CVTerm("PRIDE:0000482", "PRIDE", "Number of MS1 spectra",
metadata.addMSData(new CVTerm("PRIDE:0000482", "PRIDE", "Number of MS2 spectra",
msLevels[MSOrderType.Ms2].ToString()));
if (msLevels[MSOrderType.Ms3] > 0)
metadata.addMSData(new CVTerm("PRIDE:0000483", "PRIDE", "Number of MS1 spectra",
metadata.addMSData(new CVTerm("PRIDE:0000483", "PRIDE", "Number of MS3 spectra",
msLevels[MSOrderType.Ms3].ToString()));

metadata.addMSData(new CVTerm("PRIDE:0000472", "PRIDE", "MS min charge",
Expand Down