-
Notifications
You must be signed in to change notification settings - Fork 7
feat(medcat): CU-869bydfx8 Allow downloading missing plugins #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medcat): CU-869bydfx8 Allow downloading missing plugins #311
Conversation
…ugin installation
|
Task linked: CU-869bydfx8 Add option to download missing plugins |
tomolopolis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice - I think we need a guide internally to do some 🐶 fooding
| "plugin_version": "main" | ||
| } | ||
| ], | ||
| "requires_auth": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this repo does require_auth no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, absolutely! I remember fixing it at some point, but I think I changed schema a little afterwards and forgot to circle back. Should be fixed now.
The issue with plugins so far has been that it would be difficult for users to install them unless they know what they are or where they are how how to install them.
This PR attempts to rectify that. Its main contribution is as follows:
python -m medcat install-plugins <plugin list>medcat/plugins/data/plugin_catalog.jsonA sample stack trace when trying to load a
medcat-glinermodel:Yet after doing the install as per the above hint, the model load works as expected.
EDIT:
Also verified that the wheel does in fact contain the *.json data using: