Conversation
karntrehan
requested changes
Nov 14, 2024
cogs/discordDataScraper.py
Outdated
| async def on_message(self, message): | ||
| pass | ||
| # contributor = SupabaseClient().read( | ||
| # contributor = PostgresClient().read( |
Contributor
There was a problem hiding this comment.
Lets delete the commented code.
cogs/badges.py
Outdated
| userBadges["achievements"].append(self.discordXGithubBadge) | ||
|
|
||
| discordMemberData = SupabaseClient().read( | ||
| discordMemberData = PostgresClient().read( |
Contributor
There was a problem hiding this comment.
Can we create 1 class level instance of postgresclient please? Creating a new one each time seems unncessary.
cogs/badges.py
Outdated
| table="connected_prs", query_key="raised_by", query_value=github_id | ||
| ), | ||
| "merged": SupabaseClient(table="connected_prs").read( | ||
| "merged": PostgresClient(table="connected_prs").read( |
Contributor
There was a problem hiding this comment.
This seems to be a different syntax. We should have a uniform syntax across the board.
cogs/listeners/role_events_cog.py
Outdated
| if role.name.startswith("College:"): | ||
| orgName = role.name[len("College: ") :] | ||
| SupabaseClient().addChapter(roleId=role.id, orgName=orgName, type="COLLEGE") | ||
| PostgresClient().addChapter(roleId=role.id, orgName=orgName, type="COLLEGE") |
Contributor
There was a problem hiding this comment.
Class level instance here as well. Lets do it for all classes.
cogs/userInteractions.py
Outdated
| # async def give_badges(self, ctx): | ||
| # self.give_discord_badges.start() | ||
|
|
||
| @tasks.loop(minutes=10) |
Contributor
There was a problem hiding this comment.
Seems to be a duplicate? Merging issue?
karntrehan
approved these changes
Nov 15, 2024
Migration to postgres bug fixes
Deploy ready branch
Signed-off-by: Srijan-SS02 <codeofficialsrijansriv@gmail.com>
Collaborator
|
Updated pull request added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.