Deduplicate walltime perf symbols, unwind data and debug info across pids #240
+1,916
−480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced in 8b37208. We now filter pids using `bench_pids`, except for `exec-harness` integrations, where we take all pids.
GuillaumeLagrange
changed the title
- Store pid-agnostic data in a file or json map under the key
`{file_name}-{rest_of_path_hash}.{extension}` for each elf
- For each pid, store pid specific data, mostly the computed
load_bias from where each module was loaded into memory at
runtime, alongside a key to retrieve the pid-agnostic data
This way, we only write to disk relevant parts of the information.
…refactor The use case for this is quite scoped, and it will most likely get removed later, but for now, it helps compute two consecutive runs, one with the current version of the runner, and one post refactor, and highlight the differences in the report data. It is expected to be used with ASLR disabled, otherwise all load_bias will be randomized across runs.
GuillaumeLagrange
force-pushed
the
cod-2138-deduplicate-perf-maps-and-unwind_data
branch
from
99e0ea4 to
1a32faa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: deduplicate symbol maps, unwind_data and debug info
{file_name}-{rest_of_path_hash}.{extension}for each elfload_bias from where each module was loaded into memory at
runtime, alongside a key to retrieve the pid-agnostic data
This way, we only write to disk relevant parts of the information.