fix: use subset check for CMEC bundle dimension validation #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different data requirements (e.g. CMIP6 vs obs4MIPs) have different group_by fields, so bundle dimensions vary per execution. The validation now checks that bundle dimensions are a subset of diagnostic facets rather than requiring an exact match. Fixes obs4MIPs test case for regional-historical-trend where the bundle has (source_id, variable_id, region, metric) but facets also include grid_label and member_id from the CMIP6 group_by.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
validate_cmec_bundlesto check that bundle dimensions are a subset of diagnostic facets, rather than requiring exact equalitygroup_byfields that get prepended as dimensions viaprepend_dimensions, so bundle dimensions legitimately vary per executionFixes the
regional-historical-trend/obs4mipstest case where the bundle produces(source_id, variable_id, region, metric)butfacetsalso includesgrid_labelandmember_idfrom the CMIP6group_by.Test plan
TestValidateCmecBundlesunit tests pass (3/3)