Add CAIP-350 profiles for bip122, starknet#172
Open
0xrcinus wants to merge 9 commits intoChainAgnostic:mainfrom
Open
Add CAIP-350 profiles for bip122, starknet#1720xrcinus wants to merge 9 commits intoChainAgnostic:mainfrom
0xrcinus wants to merge 9 commits intoChainAgnostic:mainfrom
Conversation
…espaces into 350-bip122-starknet
bumblefudge
reviewed
Feb 11, 2026
bip122/caip350.md
Outdated
|
|
||
| ### Extra considerations | ||
|
|
||
| Wallets and other software are expected to be able to fetch the extra information needed to convert from [CAIP-2](caip2.md) to produce the corresponding identifier defined by this standard. |
Collaborator
There was a problem hiding this comment.
I would maybe remove this since in this profile there IS no extra information needed?
bumblefudge
reviewed
Feb 11, 2026
bip122/caip350.md
Outdated
|
|
||
| ### Extra considerations | ||
|
|
||
| Wallets and other software are expected to be able to fetch the extra information needed to convert from [CAIP-2](caip2.md) to produce the corresponding identifier defined by this standard. |
Collaborator
There was a problem hiding this comment.
I would maybe remove this since in this profile there IS no extra information needed?
bumblefudge
reviewed
Feb 11, 2026
starknet/caip350.md
Outdated
|
|
||
| ### Extra considerations | ||
|
|
||
| Wallets and other software are expected to be able to fetch the extra information needed to convert from [CAIP-2](caip2.md) to produce the corresponding identifier defined by this standard. |
bumblefudge
approved these changes
Feb 11, 2026
Collaborator
bumblefudge
left a comment
bumblefudge
left a comment
There was a problem hiding this comment.
Other than removing what I think are vestigial implementation considerations re: CAIP-2 non-roundtrippability, I think these are good to go?
I'd also welcome a PR fixing the solana headers, I just noticed them when working on this PR.
Author
|
thanks so much, updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CAIP-350 profile for bip122 and starknet, based on the latest template