Add console command to reveal cave and dungeon names #9495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickxiv
reviewed
Jan 15, 2026
forge-gui-mobile/src/forge/adventure/stage/ConsoleCommandInterpreter.java
Outdated
Show resolved
Hide resolved
nickxiv
reviewed
Feb 5, 2026
| return "Please specify at least one PointOfInterest type (e.g. \"reveal cave\", \"reveal dungeon\", \"reveal town\", \"reveal capital\")."; | ||
| } | ||
| int revealed = 0; | ||
| for (PointOfInterest poi : save.getWorld().getAllPointOfInterest()) { |
There was a problem hiding this comment.
This looks like it's currently iterating over every POI, regardless of if it matches the type passed in. Could enhance performance by filtering these down to just the ones that match the passed in type(s).
Author
There was a problem hiding this comment.
I can refactor this for readability, but that won’t change performance: we still need to inspect all POIs at least once without a precomputed type index. To actually reduce iteration cost, we’d need to add a typed lookup/index in world POI storage, which is a larger design change. If that already exists and I missed it, please let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
reveal caves dungeons.