Open
Conversation
Author
|
Is this library still maintained? :( |
ahovgaard
reviewed
Sep 28, 2023
| def application do | ||
| [ | ||
| extra_applications: [:logger] | ||
| extra_applications: [:logger, :private_key] |
Contributor
There was a problem hiding this comment.
Shouldn't it be :public_key?
Suggested change
| extra_applications: [:logger, :private_key] | |
| extra_applications: [:logger, :public_key] |
There was a problem hiding this comment.
I'm not seeing this fix in the current easy_ssl release version: "1.3.0",
defp deps do
[
{:easy_ssl, "~> 1.3"},
]
end
mix deps.get && mix deps.compile resulted in:
==> easy_ssl
Compiling 1 file (.ex)
== Compilation error in file lib/easy_ssl.ex ==
** (ArgumentError) lib file public_key/include/OTP-PUB-KEY.hrl could not be found
(elixir 1.16.3) lib/record/extractor.ex:41: Record.Extractor.from_lib_file/1
(elixir 1.16.3) lib/record/extractor.ex:18: Record.Extractor.from_or_from_lib_file/1
(elixir 1.16.3) lib/record/extractor.ex:9: Record.Extractor.extract_all/1
lib/easy_ssl.ex:10: (module)
could not compile dependency :easy_ssl, "mix compile" failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile easy_ssl --force", update it with "mix deps.update easy_ssl" or clean it with "mix deps.clean easy_ssl"
But as soon as I added :public_key to my deps/easy_ssl/mix.exs file it compiled with no problem:
==> easy_ssl
Compiling 1 file (.ex)
Generated easy_ssl app
I'm on Ubuntu 22.04.4 LTS and had the same issue with elixir via apt and via asdf.
So I guess there is a merge conflict for this branch maybe?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Elixir 1.15 introduces code path pruning this library cannot compile anymore without the
:private_keyapplication inextra_application.