Filter out events, Remove custom output, Add multi file drop.#4
Open
MrPurple6411 wants to merge 5 commits intoCabbageCrow:masterfrom
MrPurple6411:master
Open
Filter out events, Remove custom output, Add multi file drop.#4MrPurple6411 wants to merge 5 commits intoCabbageCrow:masterfrom MrPurple6411:master
MrPurple6411 wants to merge 5 commits intoCabbageCrow:masterfrom
MrPurple6411:master
Conversation
The first change I made is this does not publicize fields with names that match event names in that type and so it should not have the same issue as the current version. The second change I made is that it no longer can do custom output locations and names but instead it CAN now drop any number of assemblies on the exe at a time and it will publicize them all and put them all in the publicized_assemblies folder that it creates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first change I made is this does not publicize fields with names that match event names in that type and so it should not have the same issue as the current version.
The second change I made is that it no longer can do custom output locations and names but instead it CAN now drop any number of assemblies on the exe at a time and it will publicize them all and put them all in the publicized_assemblies folder that it creates.
I have found with these 2 changes I no longer have to worry about IF I want to use the publicizer or not and just use it for everything now as it makes harmony patching SO much easier and no longer gives ambiguity issues with events such as OnEquip or OnAdd