Add secrets engines abstraction#63
Open
damian-kwolek wants to merge 9 commits intoCSharpRU:developfrom
Open
Conversation
added 9 commits
July 1, 2023 23:49
* Corrected phpdoc for namespace * PSR-12 formatting
* Using correct RuntimeException
* Added Cubbyhole implementation
* Added missing phpdoc
CSharpRU
reviewed
Nov 22, 2023
| * | ||
| * @package Vault\SecretsEngine | ||
| */ | ||
| abstract class AbstractSecretsEngine |
Owner
There was a problem hiding this comment.
Needs an interface for all secret engines :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I'm suggesting adding another layer of abstraction based on Vault's own API docs - Secrets Engines (overlays).
They can be used to streamline path generation for specific jobs and objectify whole Vault transaction.
For example, in case of KeyValue Version 2:
This PR:
application/jsonmay be rejected by newer Vault versionsI made sure it does NOT break backwards compability, so you can still use old way of raw calling client directly.