Conversation
| } | ||
| body { | ||
| background-color: #ffffff; | ||
| background-color: var(--d2l-color-background-base); |
There was a problem hiding this comment.
I think this should be:
background-color: var(--d2l-color-container-base, #ffffff);On the next line, I might suggest also setting:
color: var(--d2l-color-text-static-standard, #202122);There was a problem hiding this comment.
Those are the palette variables that are currently proposed: BrightspaceUI/core#6585.
There was a problem hiding this comment.
These --d2l-color-* variables will never actually be defined though right? Like nothing's including core's color palette and can't because this repo can't depend on core.
There was a problem hiding this comment.
Well, if colors are not included then dark mode would not work either. Since to use dark mode you would need to include it, this just makes the background and color with dark mode work with tests
There was a problem hiding this comment.
As soon as a component imports colors.js, these variables will be defined.
There was a problem hiding this comment.
Yeah true, haha so ironically the testing library can't test its own dark mode
3 participants
GAUD-9494
These are the part of the changes that don't require any refactoring. We would add tests like we do for
rtljust adding the option to the fixture.