Throw a KeyError exception if obsolete names are used#191
Merged
kbabioch merged 2 commits intoBouni:mainfrom Oct 24, 2025
Merged
Throw a KeyError exception if obsolete names are used#191kbabioch merged 2 commits intoBouni:mainfrom
kbabioch merged 2 commits intoBouni:mainfrom
Conversation
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Author
Collaborator
|
For me this seems reasonable and since its configurable, it should make everyone happy. Anyone against merging this, since it has been lying around for quite a while? |
Owner
|
LGTM @kbabioch Feel free to merge this one |
Collaborator
|
I've rebased it on top current master and self-approved it, since this was a trivial change. Hopefully no one feels offended by this, wanted to proceed with this one, since @Bouni told us that we may proceed in this previous comment. |
kbabioch
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike #187, this version no longer supports obsolete names. Instead, it returns an exception, compelling the user to switch to the latest version.
The names are passed directly to the constructor, eliminating the need for additional files or constants. This allows for the identification of names from previous versions without the need to execute the code.
Fixes #168.
Replaces #171 and #187.