Convert gl-sdk NAPI bindings from Synchronous to Aynchronous calls#669
Closed
ShahanaFarooqui wants to merge 2 commits intoBlockstream:mainfrom
Closed
Convert gl-sdk NAPI bindings from Synchronous to Aynchronous calls#669ShahanaFarooqui wants to merge 2 commits intoBlockstream:mainfrom
ShahanaFarooqui wants to merge 2 commits intoBlockstream:mainfrom
Conversation
Collaborator
Author
|
Closing because these commits are already covered in #667 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the initial implementation, I overlooked adding asynchronous handling to all I/O-bound NAPI bindings. Since gl-sdk exposes a synchronous Rust API, we use
tokio::task::spawn_blockinginstead of native async/await. This ensures blocking operations are offloaded to a thread pool and do not impact the Node.js event loop.awaitthese methods.bindings-typescripttask.Continued after:
Add TypeScript support via N-API (#659)