Skip to content

chore: update jsdoc for hmacv4#8112

Merged
MohammedRyaan786 merged 1 commit intomasterfrom
CAAS-660-canonicalization-helper
Feb 12, 2026
Merged

chore: update jsdoc for hmacv4#8112
MohammedRyaan786 merged 1 commit intomasterfrom
CAAS-660-canonicalization-helper

Conversation

@MohammedRyaan786
Copy link
Contributor

@MohammedRyaan786 MohammedRyaan786 commented Feb 11, 2026

TICKET: CAAS-660

This pull request updates the documentation for the calculateV4RequestHmac function in hmacv4.ts to reflect new HTTP header names for authentication. The change ensures the code comments match the current header naming conventions.

Header naming updates:

  • Updated the example headers in the documentation to use the new names: X-Request-Timestamp, X-Signature, X-Content-SHA256, and X-Auth-Request-Id, replacing the old names.

@MohammedRyaan786 MohammedRyaan786 marked this pull request as ready for review February 11, 2026 21:11
@MohammedRyaan786 MohammedRyaan786 requested review from a team as code owners February 11, 2026 21:11
Copy link
Contributor

@lokesh-bitgo lokesh-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MohammedRyaan786 MohammedRyaan786 merged commit a4f8473 into master Feb 12, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants