feat(sdk-coin-sol): add WASM-based transaction parsing via @bitgo/wasm-solana#7957
Open
feat(sdk-coin-sol): add WASM-based transaction parsing via @bitgo/wasm-solana#7957
Conversation
lcovar
force-pushed
the
BTC-0-draft-example-sol-decoding
branch
27 times, most recently
from
d32c089 to
bb885ad
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lcovar
force-pushed
the
BTC-0-draft-example-sol-decoding
branch
2 times, most recently
from
f5732ce to
97c511d
Compare
lcovar
force-pushed
the
BTC-0-draft-example-sol-decoding
branch
9 times, most recently
from
c2bcda3 to
c03ea63
Compare
lcovar
force-pushed
the
BTC-0-draft-example-sol-decoding
branch
4 times, most recently
from
c0e8e7f to
63284b8
Compare
OttoAllmendinger
requested changes
Feb 11, 2026
Contributor
OttoAllmendinger
left a comment
OttoAllmendinger
left a comment
There was a problem hiding this comment.
we can move towards bigint a little bit more
where external interfaces force us to string keep it
| ]; | ||
|
|
||
| const outputs: { address: string; amount: string; memo?: string }[] = []; | ||
| let outputAmount = '0'; |
Contributor
There was a problem hiding this comment.
Suggested change
| let outputAmount = '0'; | |
| let outputAmount = 0n; |
| address: instr.params.toAddress, | ||
| amount: instr.params.amount, | ||
| }); | ||
| outputAmount = (BigInt(outputAmount) + BigInt(instr.params.amount)).toString(); |
Contributor
There was a problem hiding this comment.
let's avoid the internal bigint casts - why is instr.params.amount not a bigint already?
modules/sdk-coin-sol/src/sol.ts
Outdated
| // Derive outputs and tokenEnablements from combined instructions | ||
| const outputs: TransactionRecipient[] = []; | ||
| const tokenEnablements: ITokenEnablement[] = []; | ||
| let outputAmount = new BigNumber(0); |
Contributor
There was a problem hiding this comment.
yet another way to sum up things... use bigint instead
|
|
||
| /** Transaction ID (first signature, base58 encoded) */ | ||
| get id(): string { | ||
| if (!this._wasmTransaction) return UNAVAILABLE_TEXT; |
Contributor
There was a problem hiding this comment.
I'm guessing the interface forces us to do this ugliness?
Contributor
Author
There was a problem hiding this comment.
Unfortunately yes, base class forces the return type of string while _id can be string | undefined so it's a bit silly. We have to return a string, i guess we can return an empty string.
Seeing what it would take to update the base class to accept undefined as a return type. It would cause some breaking changes though but lets see. 🤖
lcovar
force-pushed
the
BTC-0-draft-example-sol-decoding
branch
2 times, most recently
from
38e4bc7 to
da3dc95
Compare
lcovar
force-pushed
the
BTC-0-draft-example-sol-decoding
branch
from
da3dc95 to
564ed1f
Compare
…m-solana This PR introduces WASM-based transaction parsing as an alternative to the legacy @solana/web3.js approach. The WASM implementation provides cleaner parsing with zero web3.js dependencies for transaction decoding. Key changes: - Add WasmTransaction class (~150 lines vs 800+ in legacy Transaction) - Add wasmInstructionMapper to convert WASM parsed instructions to SDK format - Add wasmInstructionCombiner to derive transaction types from instructions - Update sol.ts to extract transaction IDs using WASM parsing - Add comprehensive tests including Jito staking verification Dependencies: - @bitgo/wasm-solana@1.6.0 (from npm) - Webpack alias added for browser builds Ticket: BTC-3023
lcovar
force-pushed
the
BTC-0-draft-example-sol-decoding
branch
from
564ed1f to
0b3225b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces WASM-based transaction parsing as an alternative to
the legacy @solana/web3.js approach. The WASM implementation provides
cleaner parsing with zero web3.js dependencies for transaction decoding.
Key changes:
Dependencies: