Avoid http-level retries during upload requests#556
Open
olzhasar-reef wants to merge 1 commit intomasterfrom
Open
Avoid http-level retries during upload requests#556olzhasar-reef wants to merge 1 commit intomasterfrom
olzhasar-reef wants to merge 1 commit intomasterfrom
Conversation
olzhasar-reef
force-pushed
the
avoid-b2http-retries-upload
branch
2 times, most recently
from
b00e648 to
bc212bb
Compare
Pass try_count=1 to b2http during upload requests to force token refresh on errors. This change also eliminates the need for a previous B2RequestTimeoutDuringUpload workaround, so it's removed. The exception itself is preserved, as it's a part of the public API.
olzhasar-reef
force-pushed
the
avoid-b2http-retries-upload
branch
from
bc212bb to
b16641d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the b2http logic to avoid any retries during the upload
requests. Previously, the http layer would still proceed with retries
during upload failures, preventing the upload manager from issuing a new
upload token.
There was a workaround only for timeout errors, but it didn't quite work as
expected.