[ARO] Update aro module with features from 2025_07_25 API#32796
[ARO] Update aro module with features from 2025_07_25 API#32796cadenmarchese wants to merge 4 commits intoAzure:devfrom
aro module with features from 2025_07_25 API#32796Conversation
* changes are identical to the downstream with the exception of * rp_mode_development functionality which is removed, and preview * extension metadata which is also removed.
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This PR updates the ARO (Azure Red Hat OpenShift) module to support features from the 2025_07_25 API, including a major SDK upgrade from version 1.5.0 to 3.0.0 and the addition of managed identity support for ARO clusters.
Changes:
- Upgrades azure-mgmt-redhatopenshift SDK from 1.5.0 to 3.0.0
- Adds comprehensive managed identity support including platform workload identities and cluster identity management
- Introduces extensive unit and integration test coverage (1900+ lines of new tests)
- Adds AAZ commands for identity management operations
- Refactors validation logic and adds new validators for managed identity features
- Updates parameter definitions and help text to reflect new capabilities
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Updates azure-mgmt-redhatopenshift dependency to ~=3.0.0 |
| test_validators.py | Adds 1355 lines of unit tests for validator functions |
| test_dynamic_validators.py | Adds 616 lines of unit tests for dynamic validation |
| test_aro_helpers.py | Relocates and updates helper function tests with mocking |
| test_aro_scenario.py | Adds integration tests for ARO cluster lifecycle |
| custom_preparers.py | Updates license header and super() call syntax |
| custom.py | Adds managed identity support, identity deletion, refactors validation logic |
| _validators.py | Adds validators for managed identity, platform workload identities, cluster identity, upgradeable_to |
| _params.py | Adds parameters for managed identity features, updates help text with defaults |
| _dynamic_validators.py | Adds validation for managed identity delete permissions |
| _actions.py | New file implementing AROPlatformWorkloadIdentityAddAction |
| aaz/latest/identity/ | AAZ-generated commands for identity create/delete operations |
| Multiple files | License header changes from MIT to Apache 2.0, import reorganization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/aro/tests/latest/unit/test_dynamic_validators.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/aro/tests/latest/unit/test_aro_helpers.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/aro/_dynamic_validators.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/aro/aaz/latest/identity/__cmd_group.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/aro/tests/latest/unit/test_validators.py
Outdated
Show resolved
Hide resolved
* fix import mismatches * don't register aaz identity commands * fix license mismatches
Related command
az aroDescription
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.