Skip to content

Conversation

@lilypan26
Copy link
Contributor

What this PR does / why we need it:
Adds validation against critical kernel errors and aims to catch issues like these: https://supportability.visualstudio.com/AzureContainers/_workitems/edit/163429

Which issue(s) this PR fixes:

Fixes #

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new E2E validation step to scan kernel logs for critical errors (panic/lockup/OOM/I/O), intended to catch severe node issues during validation runs.

Changes:

  • Added ValidateKernelLogs validator that greps dmesg for critical kernel error patterns and fails the scenario if matches are found.
  • Wired the new validator into ValidateCommonLinux so it runs as part of default Linux validations.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
e2e/validators.go Introduces ValidateKernelLogs with category-based regex matching and failure reporting/logging.
e2e/validation.go Adds ValidateKernelLogs to the common Linux validation sequence.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 10, 2026 21:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings February 10, 2026 23:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

@lilypan26 lilypan26 merged commit 2c38c60 into main Feb 11, 2026
30 of 32 checks passed
@lilypan26 lilypan26 deleted the lily/add-kernel-warning-e2e-validator branch February 11, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants