Add features and prepare for the addition of Barrage, Chapter, and Equipment data functions#1
Conversation
…ions Changed: - Added barrage, voiceline, chapters to the updater system - Added barrage. voiceline, chapters sources to SaratogaUtil - Added barrage, voiceline, chapters to the main Saratoga class - Changed: how update checking works
Changed: - Regenerated docma docs - Minor info addition
Changes: - Added .filter() and .search() functions for ship data and equipment data - Regenerate docma docs
Changed: - version number (i forgot lmao)
Changed: - add checks for file exists before accessing file
Changed: - how checking for updates works
changed: - add jest test - add github actions file
Member
|
On the side note, I will merge this once the barrage, chapter and equip data functions are done |
Deivu
added
documentation
Changes: - Comply to: https://docs.google.com/document/d/16rmt309dP2iOlG0tJL2XHgdMGrieUbgmWv-aFVJKmhU/edit - Fix jest causing errors in eslint - Restructure jest tests
Author
|
Barrage, chapter and equip data functions are soon TM |
Author
|
Ill also fix the non-jest vanilla JS tests soon TM |
Author
|
On the side note, there is no eta for barrage, chapter and equip data functions because there are no specs for it yet. If you would like to suggest specs please make changes this doc. Thanks! |
Changes: - Regenerated docma docs - Change version number
Changed: - Legacy api support - Version number - Regenerated docs
This version adds: - Barrage functions - Typings for voicelines, barrages, and ships - Regenerated docs - Partially added JP info
Member
|
Legacy class can be removed later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds filter and search functions for the ship and equipments classes and prepares for the addition of Barrage, Chapter, and Equipment data functions. These changes are tested. Actually adding Barrage, Chapter, and Equipment functions are in the works. Jest tests are also added for automating tests. Please look into commit messages for more details.