Open
Conversation
…ration tests - Add `conftest.py` with 16 shared pytest fixtures for mock providers, platforms, events, contexts, and database instances - Create structured test data in `tests/fixtures/` including configs, messages, and a sample plugin for consistent test inputs - Implement integration test infrastructure in `tests/integration/` with specialized fixtures for multi-component testing - Add unit test directory structure in `tests/unit/` - Fix circular import in `astrbot/core/star/register/star.py` - Update existing tests for compatibility with new fixtures: - `test_dashboard.py`: Fix async fixture scope issues - `test_plugin_manager.py`: Use new Context fixture with cron_manager - `test_kb_import.py`: Align with async fixture patterns - `test_main.py`: Improve mock handling - Add `TEST_REQUIREMENTS.md` documenting ~415 test cases to implement - Add pytest configuration to `pyproject.toml` with markers and settings - Update `Makefile` with test commands (test, test-unit, test-cov, etc.) Test coverage baseline: 34% (203 tests passing) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dosubot
bot
added
the
size:XXL
Contributor
Summary of ChangesHello @whatevertogo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在通过引入一个全面的测试框架来显著提升 AstrBot 项目的测试能力和代码质量。它不仅建立了统一的测试基础设施和清晰的测试目录结构，还重构了现有测试以适应新标准，并修复了一个关键的循环导入问题。这些改进将使开发人员能够更高效地编写、运行和维护测试，从而提高项目的稳定性和可维护性，并为未来的功能开发提供坚实的基础。 Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
dosubot
bot
added
the
area:core
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - 我发现了 3 个问题，并提供了一些整体反馈：
- 在 tests/init.py 中，你通过
__all__暴露了create_mock_llm_response和create_mock_message_component，但这些符号只在 tests/conftest.py 中定义且从未被导入，因此from tests import create_mock_llm_response会失败；请要么在 tests/init.py 中导入它们，要么将它们从__all__中移除。 - 测试
test_fixture_plugin_can_be_imported_in_isolated_process每次运行都会启动一个子进程，这相对较慢，而且在失败时更难调试；除非确实需要验证进程级隔离，否则建议重构为纯 Python 的导入测试（例如在同一进程中使用 importlib）。 - 全局 conftest 和集成测试的 conftest 都修改了 sys.path 和环境变量；为了降低未来测试中出现意外交互的风险，最好将这类设置集中到一个地方（例如单一的 conftest），或者更严格地限定这些修改的作用范围。
给 AI Agents 的提示
Please address the comments from this code review:
## Overall Comments
- In tests/__init__.py you expose `create_mock_llm_response` and `create_mock_message_component` via `__all__`, but these symbols are only defined in tests/conftest.py and never imported, so `from tests import create_mock_llm_response` will fail; either import them into tests/__init__.py or drop them from `__all__`.
- The test `test_fixture_plugin_can_be_imported_in_isolated_process` spawns a subprocess on every run, which can be relatively slow and harder to debug when it fails; consider refactoring to a pure-Python import test (e.g., using importlib within the same process) unless there is a strong need to validate process-level isolation.
- Both the global conftest and integration conftest mutate sys.path and environment variables; it might be safer to centralize this setup (e.g., in a single conftest) or to scope the mutations more narrowly to reduce the risk of surprising interactions in future tests.
## Individual Comments
### Comment 1
<location> `tests/test_plugin_manager.py:64-65` </location>
<code_context>
+ (data_dir / "__init__.py").write_text("", encoding="utf-8")
+ (plugin_dir / "__init__.py").write_text("", encoding="utf-8")
+
+ monkeypatch.setenv("ASTRBOT_ROOT", str(test_root))
+ if str(test_root) not in sys.path:
+ sys.path.insert(0, str(test_root))
</code_context>
<issue_to_address>
**suggestion (testing):** Avoid leaking `sys.path` / environment changes from `plugin_manager_pm` fixture across tests
This fixture mutates global state (`ASTRBOT_ROOT`, `sys.path`) without restoring it, which can make tests order-dependent or flaky, especially under parallel runs. Please either use `monkeypatch` for `sys.path` as well, or switch to a `yield`-style fixture that captures and restores `sys.path` (and any env changes) to keep tests isolated.
</issue_to_address>
### Comment 2
<location> `tests/unit/test_fixture_plugin_usage.py:16-25` </location>
<code_context>
+ assert metadata_file.exists()
+
+
+def test_fixture_plugin_can_be_imported_in_isolated_process():
+ plugin_file = get_fixture_path("plugins/fixture_plugin.py")
+ repo_root = Path(__file__).resolve().parents[2]
+
+ script = "\n".join(
+ [
+ "import importlib.util",
+ f'plugin_file = r"{plugin_file}"',
+ "spec = importlib.util.spec_from_file_location('fixture_test_plugin', plugin_file)",
+ "assert spec is not None",
+ "assert spec.loader is not None",
+ "module = importlib.util.module_from_spec(spec)",
+ "spec.loader.exec_module(module)",
+ "plugin_cls = getattr(module, 'TestPlugin', None)",
+ "assert plugin_cls is not None",
+ "assert hasattr(plugin_cls, 'test_command')",
+ "assert hasattr(plugin_cls, 'test_llm_tool')",
+ "assert hasattr(plugin_cls, 'test_regex_handler')",
+ ],
+ )
+
+ result = subprocess.run(
</code_context>
<issue_to_address>
**suggestion (testing):** Consider marking the subprocess-based fixture plugin test as `@pytest.mark.slow`
This test starts a real Python subprocess, which is slower than in-process tests. Since a `slow` marker already exists in `tests/conftest.py`, please add `@pytest.mark.slow` so it can be skipped in quick runs (e.g. `-m "not slow"`) while still running in full test suites.
Suggested implementation:
```python
import pytest
def test_fixture_plugin_files_exist():
```
```python
@pytest.mark.slow
def test_fixture_plugin_can_be_imported_in_isolated_process():
```
If `pytest` is already imported elsewhere in this file, you should remove the duplicate `import pytest` introduced by the first change block to avoid redundant imports.
</issue_to_address>
### Comment 3
<location> `tests/__init__.py:16-18` </location>
<code_context>
+ └── test_*.py # 根级别测试文件
+"""
+
+__all__ = [
+ "create_mock_llm_response",
+ "create_mock_message_component",
+]
</code_context>
<issue_to_address>
**issue (bug_risk):** `__all__` exports helpers that are not defined in this module
These names are only defined in `tests/conftest.py` and aren’t imported into `tests/__init__`, so they’re not actually available as `tests.create_mock_llm_response` / `tests.create_mock_message_component`. Either import them here (e.g. `from .conftest import create_mock_llm_response, create_mock_message_component`) or update `__all__` to only list symbols that this module really exports, to avoid import failures and a misleading package API.
</issue_to_address>帮我变得更有用！请对每条评论点击 👍 或 👎，我会根据你的反馈改进之后的评审。
Original comment in English
Hey - I've found 3 issues, and left some high level feedback:
- In tests/init.py you expose
create_mock_llm_responseandcreate_mock_message_componentvia__all__, but these symbols are only defined in tests/conftest.py and never imported, sofrom tests import create_mock_llm_responsewill fail; either import them into tests/init.py or drop them from__all__. - The test
test_fixture_plugin_can_be_imported_in_isolated_processspawns a subprocess on every run, which can be relatively slow and harder to debug when it fails; consider refactoring to a pure-Python import test (e.g., using importlib within the same process) unless there is a strong need to validate process-level isolation. - Both the global conftest and integration conftest mutate sys.path and environment variables; it might be safer to centralize this setup (e.g., in a single conftest) or to scope the mutations more narrowly to reduce the risk of surprising interactions in future tests.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In tests/__init__.py you expose `create_mock_llm_response` and `create_mock_message_component` via `__all__`, but these symbols are only defined in tests/conftest.py and never imported, so `from tests import create_mock_llm_response` will fail; either import them into tests/__init__.py or drop them from `__all__`.
- The test `test_fixture_plugin_can_be_imported_in_isolated_process` spawns a subprocess on every run, which can be relatively slow and harder to debug when it fails; consider refactoring to a pure-Python import test (e.g., using importlib within the same process) unless there is a strong need to validate process-level isolation.
- Both the global conftest and integration conftest mutate sys.path and environment variables; it might be safer to centralize this setup (e.g., in a single conftest) or to scope the mutations more narrowly to reduce the risk of surprising interactions in future tests.
## Individual Comments
### Comment 1
<location> `tests/test_plugin_manager.py:64-65` </location>
<code_context>
+ (data_dir / "__init__.py").write_text("", encoding="utf-8")
+ (plugin_dir / "__init__.py").write_text("", encoding="utf-8")
+
+ monkeypatch.setenv("ASTRBOT_ROOT", str(test_root))
+ if str(test_root) not in sys.path:
+ sys.path.insert(0, str(test_root))
</code_context>
<issue_to_address>
**suggestion (testing):** Avoid leaking `sys.path` / environment changes from `plugin_manager_pm` fixture across tests
This fixture mutates global state (`ASTRBOT_ROOT`, `sys.path`) without restoring it, which can make tests order-dependent or flaky, especially under parallel runs. Please either use `monkeypatch` for `sys.path` as well, or switch to a `yield`-style fixture that captures and restores `sys.path` (and any env changes) to keep tests isolated.
</issue_to_address>
### Comment 2
<location> `tests/unit/test_fixture_plugin_usage.py:16-25` </location>
<code_context>
+ assert metadata_file.exists()
+
+
+def test_fixture_plugin_can_be_imported_in_isolated_process():
+ plugin_file = get_fixture_path("plugins/fixture_plugin.py")
+ repo_root = Path(__file__).resolve().parents[2]
+
+ script = "\n".join(
+ [
+ "import importlib.util",
+ f'plugin_file = r"{plugin_file}"',
+ "spec = importlib.util.spec_from_file_location('fixture_test_plugin', plugin_file)",
+ "assert spec is not None",
+ "assert spec.loader is not None",
+ "module = importlib.util.module_from_spec(spec)",
+ "spec.loader.exec_module(module)",
+ "plugin_cls = getattr(module, 'TestPlugin', None)",
+ "assert plugin_cls is not None",
+ "assert hasattr(plugin_cls, 'test_command')",
+ "assert hasattr(plugin_cls, 'test_llm_tool')",
+ "assert hasattr(plugin_cls, 'test_regex_handler')",
+ ],
+ )
+
+ result = subprocess.run(
</code_context>
<issue_to_address>
**suggestion (testing):** Consider marking the subprocess-based fixture plugin test as `@pytest.mark.slow`
This test starts a real Python subprocess, which is slower than in-process tests. Since a `slow` marker already exists in `tests/conftest.py`, please add `@pytest.mark.slow` so it can be skipped in quick runs (e.g. `-m "not slow"`) while still running in full test suites.
Suggested implementation:
```python
import pytest
def test_fixture_plugin_files_exist():
```
```python
@pytest.mark.slow
def test_fixture_plugin_can_be_imported_in_isolated_process():
```
If `pytest` is already imported elsewhere in this file, you should remove the duplicate `import pytest` introduced by the first change block to avoid redundant imports.
</issue_to_address>
### Comment 3
<location> `tests/__init__.py:16-18` </location>
<code_context>
+ └── test_*.py # 根级别测试文件
+"""
+
+__all__ = [
+ "create_mock_llm_response",
+ "create_mock_message_component",
+]
</code_context>
<issue_to_address>
**issue (bug_risk):** `__all__` exports helpers that are not defined in this module
These names are only defined in `tests/conftest.py` and aren’t imported into `tests/__init__`, so they’re not actually available as `tests.create_mock_llm_response` / `tests.create_mock_message_component`. Either import them here (e.g. `from .conftest import create_mock_llm_response, create_mock_message_component`) or update `__all__` to only list symbols that this module really exports, to avoid import failures and a misleading package API.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR establishes a comprehensive test framework infrastructure for the AstrBot project, which is a multi-platform LLM chatbot written in Python. The PR refactors existing tests to use the new framework and documents approximately 415 future test requirements.
Changes:
- Adds test infrastructure with 16 shared pytest fixtures for mocking providers, platforms, databases, and contexts
- Creates structured test directories (
tests/unit/,tests/integration/,tests/fixtures/) with proper configuration - Refactors 7 existing test files to use new fixtures and fixes async fixture scope issues
- Fixes a circular import bug in
astrbot/core/star/register/star.py
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/conftest.py | Adds 16 shared fixtures, pytest configuration hooks, and utility functions |
| tests/integration/conftest.py | Adds integration-specific fixtures for full context, LLM providers, and platforms |
| tests/init.py, tests/unit/init.py, tests/integration/init.py | Package initialization with documentation |
| tests/fixtures/init.py | Helper functions for loading test data (load_fixture, get_fixture_path) |
| tests/fixtures/plugins/*.py, *.yaml | Test plugin files for plugin system validation |
| tests/fixtures/messages/test_messages.json | Test message data fixtures |
| tests/fixtures/configs/test_cmd_config.json | Test configuration data |
| tests/test_plugin_manager.py | Refactored to use local mocks instead of external network calls |
| tests/test_dashboard.py | Fixed async fixture scopes from module to function |
| tests/test_kb_import.py | Aligned async fixture patterns |
| tests/test_main.py | Improved mock handling with namedtuple for version_info |
| tests/agent/test_truncator.py | Added explicit type hints for role parameter |
| tests/agent/test_context_manager.py | Adjusted compression threshold test |
| tests/test_quoted_message_parser.py | Added pyright directive to suppress type warnings |
| tests/unit/test_fixture_plugin_usage.py | New test validating fixture plugin can be imported |
| tests/integration/test_smoke_integration.py | New smoke test for integration context bootstrap |
| pyproject.toml | Added comprehensive pytest configuration including markers, asyncio settings, and warnings |
| Makefile | Added test commands (test, test-unit, test-integration, test-cov, test-quick) |
| tests/TEST_REQUIREMENTS.md | Comprehensive documentation of 415 test requirements across all modules |
| CLAUDE.md | Development guidance for Claude Code |
| astrbot/core/star/register/star.py | Fixed circular import by using explicit import path |
- Fix `tests/__init__.py`: Remove misleading `__all__` exports that reference functions defined in conftest.py - Fix `tests/test_plugin_manager.py`: Use `monkeypatch.syspath_prepend()` instead of manual sys.path manipulation to ensure proper cleanup Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use `pytest_asyncio.fixture` for async fixtures to ensure proper event loop handling (temp_db, mock_context, plugin_manager_pm) - Fix `plugin_manager_pm` fixture to properly cleanup database with yield/finally pattern - Add missing `ignore_version_check` parameter to mock_install_plugin - Remove unnecessary pyright ignore comments from test_quoted_message_parser.py - Improve error handling in test_fixture_plugin_usage.py - Update CLAUDE.md with correct test command - Fix docstring reference from pytest.ini to pyproject.toml Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
To use Codex here, create a Codex account and connect to github. |
Contributor
Author
|
To use Codex here, create a Codex account and connect to github. |
3 similar comments
|
To use Codex here, create a Codex account and connect to github. |
|
To use Codex here, create a Codex account and connect to github. |
|
To use Codex here, create a Codex account and connect to github. |
Contributor
Author
|
@codex 干活 |
|
To use Codex here, create a Codex account and connect to github. |
Contributor
Author
|
@codex 干活 |
|
To use Codex here, create a Codex account and connect to github. |
Member
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
Hey - 我发现了 1 个问题，并给出了一些总体反馈：
- conftest 模块通过修改 sys.path 来导入项目（在 tests/conftest.py 和 tests/integration/conftest.py 中都是如此）；建议改为依赖可编辑安装（editable install）或设置 PYTHONPATH，这样测试环境与真实场景下的导入行为更一致，也能避免一些隐蔽的路径问题。
- 环境变量 TESTING 和 ASTRBOT_TEST_MODE 在多个 conftest 中被设置；建议将其集中到一个地方（例如顶层的 conftest 或测试运行脚本）里统一配置，以减少重复并降低测试环境不一致的风险。
给 AI Agent 的提示
Please address the comments from this code review:
## Overall Comments
- The conftest modules manipulate sys.path to import the project (both in tests/conftest.py and tests/integration/conftest.py); consider relying on an editable install or PYTHONPATH instead so tests more closely match real-world import behavior and avoid subtle path bugs.
- Environment variables TESTING and ASTRBOT_TEST_MODE are set in multiple conftests; centralizing this in a single place (e.g., top-level conftest or test runner script) would reduce duplication and the risk of inconsistent test environments.
## Individual Comments
### Comment 1
<location> `pyproject.toml:117-120` </location>
<code_context>
+log_file_level = "DEBUG"
+log_file_format = "%(asctime)s [%(levelname)8s] %(message)s (%(filename)s:%(lineno)s)"
+log_file_date_format = "%Y-%m-%d %H:%M:%S"
+filterwarnings = [
+ "ignore::DeprecationWarning",
+ "ignore::PendingDeprecationWarning",
+ "ignore:.*unclosed.*:ResourceWarning",
+]
+
</code_context>
<issue_to_address>
**suggestion (bug_risk):** 忽略所有关于未关闭资源的 `ResourceWarning` 消息，可能会掩盖真实的资源泄漏问题。
这个宽泛的 `ignore:.*unclosed.*:ResourceWarning` 过滤规则会关闭对真实泄漏（文件、套接字等）的检测。请将它限定在已知噪声较多的调用点/模块上，或者调整警告过滤器（例如使用 `default`/`once`），以便新的泄漏仍然能暴露出来。
建议实现方式：
```
"default:.*unclosed.*:ResourceWarning",
```
1. 确保整个 `filterwarnings = [...]` 块定义在 `[tool.pytest.ini_options]` 段内，以便 pytest 能正确应用。
2. 如果你知道某些特定的第三方模块会产生无害但噪声很大的未关闭资源警告，可以进一步收窄该规则只针对这些模块，例如：
- `"ignore:.*unclosed.*:ResourceWarning:urllib3.connectionpool"`
同时对其他情况保留通用的 `default:.*unclosed.*:ResourceWarning`。
</issue_to_address>帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进后续的评审。
Original comment in English
Hey - I've found 1 issue, and left some high level feedback:
- The conftest modules manipulate sys.path to import the project (both in tests/conftest.py and tests/integration/conftest.py); consider relying on an editable install or PYTHONPATH instead so tests more closely match real-world import behavior and avoid subtle path bugs.
- Environment variables TESTING and ASTRBOT_TEST_MODE are set in multiple conftests; centralizing this in a single place (e.g., top-level conftest or test runner script) would reduce duplication and the risk of inconsistent test environments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The conftest modules manipulate sys.path to import the project (both in tests/conftest.py and tests/integration/conftest.py); consider relying on an editable install or PYTHONPATH instead so tests more closely match real-world import behavior and avoid subtle path bugs.
- Environment variables TESTING and ASTRBOT_TEST_MODE are set in multiple conftests; centralizing this in a single place (e.g., top-level conftest or test runner script) would reduce duplication and the risk of inconsistent test environments.
## Individual Comments
### Comment 1
<location> `pyproject.toml:117-120` </location>
<code_context>
+log_file_level = "DEBUG"
+log_file_format = "%(asctime)s [%(levelname)8s] %(message)s (%(filename)s:%(lineno)s)"
+log_file_date_format = "%Y-%m-%d %H:%M:%S"
+filterwarnings = [
+ "ignore::DeprecationWarning",
+ "ignore::PendingDeprecationWarning",
+ "ignore:.*unclosed.*:ResourceWarning",
+]
+
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Ignoring all `ResourceWarning` messages about unclosed resources can hide real resource-leak issues.
This broad `ignore:.*unclosed.*:ResourceWarning` suppression turns off detection of real leaks (files, sockets, etc.). Please scope it to known noisy call sites/modules, or adjust the warnings filter (e.g., `default`/`once`) so new leaks still surface.
Suggested implementation:
```
"default:.*unclosed.*:ResourceWarning",
```
1. Ensure the entire `filterwarnings = [...]` block is defined inside the `[tool.pytest.ini_options]` section so pytest applies it.
2. If you know specific noisy third‑party modules that generate benign unclosed‑resource warnings, you can further refine this rule to target them, e.g.:
- `"ignore:.*unclosed.*:ResourceWarning:urllib3.connectionpool"`
while keeping the general `default:.*unclosed.*:ResourceWarning` for everything else.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
建议把功能型问题多review一下，工程型建议只做参考 |
…ling in Discord and Telegram adapters
… in Discord and Telegram adapters
dosubot
bot
added
size:XL
Contributor
There was a problem hiding this comment.
Sorry @whatevertogo, your pull request is larger than the review limit of 150000 diff characters
Contributor
There was a problem hiding this comment.
Sorry @whatevertogo, your pull request is larger than the review limit of 150000 diff characters
Contributor
Author
|
Contributor
Author
|
测试应该是隔离的没问题，注意一下解决循环依赖改的一些代码就行了，我个人没看出来有问题 |
…tp, discord, and telegram adapters
Contributor
Author
|
我把改动拆分成了多个小 PR，方便大家审阅。这个 PR 目前用来代表主测试分支的整体进度。 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / 动机
This PR strengthens AstrBot’s testing infrastructure, significantly expands core-module coverage, and resolves a pipeline circular import issue discovered during test hardening.
该 PR 主要完善测试基础设施、显著提升核心模块测试覆盖率，并修复在补测过程中暴露的 pipeline 循环依赖问题。
Modifications / 改动点
1️⃣ Test Infrastructure / 测试基础设施
pyproject.tomltests/conftest.pytests/integration/conftest.pytests/unit/tests/integration/tests/agent/tests/fixtures/**Makefiletest targets:make testmake test-unitmake test-integrationmake test-covmake test-quickGoal:
2️⃣ Core Test Coverage Expansion / 核心模块覆盖扩展
Added or expanded tests for:
astr_main_agentcomputerconfigconversation_mgrcore_lifecyclecron_managerevent_buspersona_mgrUpdated existing tests:
tests/test_dashboard.pytests/test_kb_import.pytests/test_main.pytests/test_plugin_manager.pytests/agent/test_*Goals:
3️⃣ Pipeline Import-Cycle Fix / Pipeline 循环依赖修复
During coverage expansion, an implicit circular import in the pipeline module was discovered and resolved.
Changes:
astrbot/core/pipeline/__init__.pyto use lazy exportsbootstrap.pystage_order.pyscheduler.pyagent_sub_stages/internal.pyagent_sub_stages/third_party.pyImpact:
Breaking Changes
Verification / 验证步骤
uv run pytest tests/test_smoke.py \ tests/unit/test_import_cycles.py \ tests/unit/test_core_lifecycle.py \ tests/unit/test_conversation_mgr.py \ tests/unit/test_config.py \ tests/unit/test_astr_main_agent.py \ tests/unit/test_computer.py -q # 178 passed uv run pytest tests/test_kb_import.py \ tests/test_dashboard.py \ tests/test_main.py -q # 15 passed, 1 skipped uv run ruff format . # formatted / unchanged uv run ruff check . # All checks passedChecklist / 检查清单
requirements.txt和pyproject.toml文件相应位置。/ I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations inrequirements.txtandpyproject.toml.审查总结
本 PR 主要围绕测试基础设施完善、核心模块测试覆盖扩展，以及一个 pipeline 循环依赖问题的修复展开。整体属于工程质量改进型变更，不涉及功能新增。
一、测试基础设施调整
本次变更对测试体系进行了结构化整理，包括：
pyproject.toml中集中配置 pytest 相关选项（markers、asyncio、日志、收集规则等）conftest.py，统一 fixture 管理tests/目录结构（unit / integration / agent / fixtures）这些修改的主要作用是统一测试运行方式，提高测试隔离性与可维护性。
二、核心模块测试覆盖扩展
新增或强化了多个核心模块的测试，包括：
测试扩展过程中发现并暴露了 pipeline 模块中的循环依赖问题，说明测试补充对结构性问题具有一定发现能力。
三、Pipeline 循环依赖修复
针对发现的循环导入问题，进行了内部结构调整：
__init__导出方式为延迟导出该修复未改变对外接口，也未影响现有功能逻辑，属于内部结构层面的修正。
四、风险评估
整体风险较低。
总体结论
该 PR 主要提升测试结构与覆盖率，并修复一个内部循环依赖问题。
变更范围清晰，未涉及功能变更或接口调整，风险可控。