fix: apply reply_with_quote and reply_with_mention to image-only response#5219
Open
KBVsent wants to merge 2 commits intoAstrBotDevs:masterfrom
Open
fix: apply reply_with_quote and reply_with_mention to image-only response#5219KBVsent wants to merge 2 commits intoAstrBotDevs:masterfrom
KBVsent wants to merge 2 commits intoAstrBotDevs:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
嘿,我已经审查了你的改动,一切看起来都非常棒!
帮我变得更有用吧!请在每条评论上点 👍 或 👎,我会根据你的反馈来改进之后的代码审查。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
中文就行,主要面向国内用户 |
Member
|
代码本身目测没有问题。 当时那么写应该是有当时的局限性?(或者单纯没改过来?) 测试没问题的话就行。 |
Contributor
Author
Onebot TG DC这三个平台我都测试过了,目前的新增只是增加了对纯图片回复的引用和At字段增加,如果有平台不支持引用或者艾特,在适配器的部分就会自动忽略了,比如QQ_Official |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
reply_with_quoteorreply_with_mentionis enabled, both featureswere silently skipped whenever the response chain contained no
Plaintextcomponent (e.g. image-only outputs from Text-to-Image). The root cause was
an overly broad
if has_plain:guard that wrapped both features together.Modifications / 改动点
astrbot/core/pipeline/result_decorate/stage.pyRemoved the
has_plainguard that gated bothreply_with_mention(At)and
reply_with_quote(Reply) on the presence of a Plain text component.Each feature now evaluates its own existing exclusion conditions
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
requirements.txt和pyproject.toml文件相应位置。/ I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations inrequirements.txtandpyproject.toml.Summary by Sourcery
Bug Fixes:
reply-with-mention和reply-with-quote被跳过的问题。Original summary in English
Summary by Sourcery
Bug Fixes: