Skip to content

Move @babel/cli from dependencies to devDependencies#313

Open
ckundo wants to merge 1 commit intomasterfrom
move-babel-cli-to-dev-deps
Open

Move @babel/cli from dependencies to devDependencies#313
ckundo wants to merge 1 commit intomasterfrom
move-babel-cli-to-dev-deps

Conversation

@ckundo
Copy link
Contributor

@ckundo ckundo commented Feb 19, 2026

Summary

  • Moves @babel/cli from dependencies to devDependencies
  • @babel/cli is a build tool not imported at runtime by any source in src/
  • Having it in dependencies forces all consumers to install @babel/cliglobminimatch, which carries 4 high-severity ReDoS vulnerabilities (GHSA-3ppc-4f35-3m26)
  • This change eliminates those vulnerabilities for downstream consumers with zero runtime impact

Test plan

  • Verify npm test still passes (babel is still available via devDependencies)
  • Verify npm audit shows 0 high-severity vulnerabilities for a fresh consumer install

@ckundo ckundo requested a review from jv-asana February 19, 2026 21:39
@ckundo ckundo force-pushed the move-babel-cli-to-dev-deps branch from 640193d to 10f4652 Compare February 19, 2026 21:41
Copy link
Contributor

@jv-asana jv-asana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to update the mustache template for this: https://github.com/Asana/node-asana/blob/master/codegen/templates/package.mustache

@ckundo ckundo force-pushed the move-babel-cli-to-dev-deps branch from 10f4652 to 4616a3e Compare February 19, 2026 22:06
@ckundo ckundo force-pushed the move-babel-cli-to-dev-deps branch from 4616a3e to ed8e8b0 Compare February 19, 2026 22:12
@ckundo ckundo requested a review from jv-asana February 19, 2026 22:12
Copy link
Contributor

@jv-asana jv-asana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"superagent": "^6.1.0"
},
"devDependencies": {
"@babel/cli": "^7.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically since you updated package.mustache you don't need to change this since the next time we run swagger this will change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments