add on new intent override plugin for expo android#579
Open
f0wu5u wants to merge 2 commits intoAppsFlyerSDK:masterfrom
Open
add on new intent override plugin for expo android#579f0wu5u wants to merge 2 commits intoAppsFlyerSDK:masterfrom
f0wu5u wants to merge 2 commits intoAppsFlyerSDK:masterfrom
Conversation
2ada035 to
1a3ba77
Compare
jurrianlammerts
approved these changes
Dec 10, 2024
|
why not merge?🚨🚨🚨🚨🚨🚨 |
|
Please merge this. |
jp1987
reviewed
Jan 27, 2025
Co-authored-by: Jesper Paardekooper <j.paardekooper@rinkel.nl>
pchalupa
reviewed
Apr 23, 2025
|
|
||
| if (!nextContent.includes(intentImportString)){ | ||
| const packageString = `${packageName}\n` | ||
| nextContent = nextContent.replace(packageString,`${packageString}\n${intentImportString}`) |
There was a problem hiding this comment.
Add a new line at the end of the import.
Suggested change
| nextContent = nextContent.replace(packageString,`${packageString}\n${intentImportString}`) | |
| nextContent = nextContent.replace(packageString,`${packageString}\n${intentImportString}\n`) |
Contributor
|
I encountered the following error: Fixed by updating the code to: import android.content.Intent
override fun onNewIntent(intent: Intent) {
super.onNewIntent(intent)
setIntent(intent)
}
|
|
We have also encountered the issue like @saseungmin, and the suggested fix solved this issue 👍 Running on Expo 52, react-native 0.76.9. Changed both appearances of This resolves the expo issue with Android not opening deeplinks when the app is in the background! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reaction to this issue #558 and this closed PR #559.
This adds the;
by default if
import android.content.intentis not already inMainActivityand ifoverride fun onNewIntent(intent: Intent?)is not already implemented.This ultimately resolves issue with expo android not opening deeplinks when app is in background
cc: @iway1